Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest stable cadence #1167

Merged
merged 6 commits into from
Aug 29, 2023
Merged

Conversation

SupunS
Copy link
Member

@SupunS SupunS commented Aug 23, 2023

Description


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@SupunS SupunS added the Improvement Technical work without new features, refactoring, improving tests label Aug 23, 2023
@SupunS SupunS self-assigned this Aug 23, 2023
@SupunS SupunS changed the base branch from feature/stable-cadence to master August 23, 2023 20:48
@SupunS SupunS force-pushed the supun/stable-cadence branch from 5ee0099 to 09de13f Compare August 23, 2023 20:48
@SupunS SupunS force-pushed the supun/stable-cadence branch from 09de13f to 6ca1e1f Compare August 23, 2023 21:05
@SupunS SupunS force-pushed the supun/stable-cadence branch from d71b16c to b6e47e5 Compare August 25, 2023 22:18
@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (aead014) 38.43% compared to head (cdfffa1) 38.43%.

Additional details and impacted files
@@                   Coverage Diff                   @@
##           feature/stable-cadence    #1167   +/-   ##
=======================================================
  Coverage                   38.43%   38.43%           
=======================================================
  Files                          38       38           
  Lines                        1941     1941           
=======================================================
  Hits                          746      746           
  Misses                       1107     1107           
  Partials                       88       88           
Flag Coverage Δ
unittests 38.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SupunS SupunS changed the base branch from master to feature/stable-cadence August 29, 2023 19:33
@SupunS SupunS marked this pull request as ready for review August 29, 2023 19:35
@SupunS SupunS merged commit 8bcb4f3 into feature/stable-cadence Aug 29, 2023
5 checks passed
@SupunS SupunS deleted the supun/stable-cadence branch August 29, 2023 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Technical work without new features, refactoring, improving tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants