Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flow accounts create does not work in previewnet #1474

Closed
jribbink opened this issue Mar 26, 2024 · 0 comments
Closed

flow accounts create does not work in previewnet #1474

jribbink opened this issue Mar 26, 2024 · 0 comments
Assignees
@chasefleming
Labels
Feedback Improvement Technical work without new features, refactoring, improving tests

Comments

@jribbink
Copy link
Contributor

The Lilico API is used to create accounts in the Flow CLI. However, there are two issues here:

  1. Lilico api does not seem to support previewnet.
  2. CLI doesn't call a different API endpoint for previewnet (currently, there's only an if statement for testnet - so previewnet behaviour defaults to the same as mainnet)

This feature was missed when making the changes needed to support previewnet.
@chasefleming chasefleming mentioned this issue Mar 27, 2024
Merged
6 tasks
@chasefleming chasefleming moved this to 🏗 In Progress in 🌊 Flow 4D Mar 27, 2024
@chasefleming chasefleming added the Improvement Technical work without new features, refactoring, improving tests label Mar 27, 2024
@chasefleming chasefleming moved this from 🏗 In Progress to ✅ Done in 🌊 Flow 4D Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chasefleming chasefleming

Labels
Feedback Improvement Technical work without new features, refactoring, improving tests
Projects
🌊 Flow 4D
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chasefleming @jribbink