Support previewnet for accounts create
#1476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chasefleming
requested review from
Kay-Zee,
janezpodhostnik,
sideninja,
nvdtf,
bluesign,
bjartek,
jribbink and
ianthpun
as code owners
chasefleming
added
the
Improvement
nvdtf
approved these changes
Mar 27, 2024
jribbink
approved these changes
Mar 27, 2024
jribbink
reviewed
Mar 27, 2024
| @@ -259,6 +263,7 @@ func (l *lilicoAccount) create(network string) (flowsdk.Identifier, error) { | |||
| request.Header.Add("Authorization", accountToken) | |||
|
|
|||
| client := &http.Client{ | |||
| Timeout: time.Second * 20, | |||
There was a problem hiding this comment.
Should we add a timeout on getAccountCreationResult also?
There was a problem hiding this comment.
Is that in flowkit @jribbink since it's using GetTransactionByID?
There was a problem hiding this comment.
Yeah not sure. If it's not easy, don't bother... it's not that important imo
jribbink
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1474
For contributor use:
masterbranchFiles changedin the Github PR explorer