Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix contract init params #134

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

MaxStalker
Copy link
Contributor

Description

Contract init parameters can be defined on multiple lines like this:

init(
     a: Int,
     b: String
)

Previous implementation would fail to properly catch this. This PR adds changes to fix it.


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@MaxStalker MaxStalker requested a review from a team as a code owner July 28, 2023 17:27
@changeset-bot
Copy link

changeset-bot bot commented Jul 28, 2023

🦋 Changeset detected

Latest commit: 6eb29b7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@onflow/flow-cadut Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@jribbink jribbink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@jribbink jribbink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i merged the flow-cli install fix but it looks like CI is still failing, mind checking this out then we can merge?

@MaxStalker
Copy link
Contributor Author

@jribbink now it's linter :)
I will fix the issues now.

(cherry picked from commit 3c085cc)
@MaxStalker
Copy link
Contributor Author

Do you know how I can fix inter-package importing in this lerna repo?
Tests are failing cause it can't find @onflow/flow-cadut module (for example)...

@MaxStalker MaxStalker mentioned this pull request Jul 29, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants