New Standard: NFT metadata - Milestone 2 #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1/coelacant/NFTStandard.cdc
compressedMime replaced with innerMime so it can be used by linked data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is for issue #16
This PR fulfils Milestone 2 Requirement:
"Document your metadata as a Flow Improvement Proposal (FLIP)."
Improved code and added examples of final implementation that utilize shared pngs.
Fleshed out the Schema system to allow for more flexibility and ease usage by off-chain sources.
Submitted Flip PR to flow repo and began working through comments and suggestions.
Submission Links & Documents
onflow/flow#635
Requirements Check
Have have you met the milestone requirements? YES
Have you included tests (if applicable)? NA
Have you met the contribution guidelines of the repos you have submitted code to (if applicable)? YES
Other Details
Is there anything specific you'd like the PoC to know or review for?
Please review "ExampleNFT.cdc" and changes to "NFTStandard.cdc"
Are there other references, documentation, or relevant artificats to mention for this PR (ie. external links to justify design decisions, etc.)?
Not since last PR