Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RISC-V VM which can run the imperative fib benchmark #3709

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

turbolent
Copy link
Member

Description

Ported enough of the RISC-V VM by @jsproz written in Swift to Go which is able to run the imperative fib benchmark.


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent requested a review from jsproz December 4, 2024 22:25
@turbolent turbolent self-assigned this Dec 4, 2024
@turbolent turbolent requested a review from SupunS as a code owner December 4, 2024 22:25
@turbolent turbolent marked this pull request as draft December 4, 2024 22:25
Copy link

github-actions bot commented Dec 4, 2024

Cadence Benchstat comparison

This branch with compared with the base branch onflow:master commit 0963441
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

Copy link

@jsproz jsproz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very useful. Thank you for doing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants