[Account Storage Maps] Add more tests for register reads for GetDomainStorageMap()

[fxamacker]

Updates #3584

This PR adds more tests for register reads from GetDomainStorageMap() for account storage format v1 and v2.

Context

This PR addresses comment in PR #3683. Thanks @turbolent for great suggestion! 👍

Could we maybe add a test case to feature/combine-domain-payloads-and-domain-storage-maps before this PR that demonstrates the inefficiency (unnecessary reads), and then this PR could would show more clearly how the unnecessary read(s) are removed?

This PR updates these tests ported from #3683:

• TestGetDomainStorageMapRegisterReadsForNewAccount
• TestGetDomainStorageMapRegisterReadsForV1Account
• TestGetDomainStorageMapRegisterReadsForV2Account

While at it, I also updated these tests to include unique register reads (in addition to sequence of register reads). Same register can be read multiple times and all reads are included in the sequence. Since subsequent register reads are from ledger cache, unique register reads are more important for performance reasons.

Unique register reads differs from that in PR #3683 ("Reduce storage register reads when using StorageFormatV2Enabled") when using StorageFormatV2Enabled:

• For new accounts (neither v1 or v2 yet):
  • If domain storage map doesn't exist and createIfNotExists is false, old approach has 10 unique register reads, while new approach has 2 unique register reads.
• For v1 accounts:
  • If domain storage map doesn't exist and createIfNotExists is false, old approach has 4 unique register reads in tests, while new approach has 2 unique register reads.

---

• Targeted PR against master branch
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work
• Code follows the standards mentioned here
• Updated relevant documentation
• Re-reviewed Files changed in the Github PR explorer
• Added appropriate labels

[github-actions]

Cadence Benchstat comparison

This branch with compared with the base branch onflow:feature/combine-domain-payloads-and-domain-storage-maps commit caaf254
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

[turbolent]

Nice! Thank you for adding more tests 🙏

[Milad335t]

@fxamacker