Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limited string templates: \(identifier) #3585

Merged
merged 21 commits into from
Oct 18, 2024
Merged

Limited string templates: \(identifier) #3585

merged 21 commits into from
Oct 18, 2024

Conversation

RZhang05
Copy link
Contributor

@RZhang05 RZhang05 commented Sep 19, 2024 •
edited by turbolent
Loading

Working towards #3579

Description

Implementation of onflow/flips#289

This PR introduces a simple string template in the form "\(foo)", with plans to extend for expressions later.

  • Targeted PR against feature/string-templates branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@RZhang05
Copy link
Contributor Author

Opened for early feedback.

  • Need to add more tests across all stages of the feature
  • Implementation questions marked with STRINGTODO in the code
  • Further consider handling (or lack of handling) of error cases in the lexer and parser

@RZhang05 RZhang05 mentioned this pull request Sep 20, 2024
Closed
6 tasks
SupunS
SupunS reviewed Sep 23, 2024
View reviewed changes
runtime/parser/lexer/lexer.go Outdated Show resolved Hide resolved
runtime/parser/lexer/lexer.go Outdated Show resolved Hide resolved
@RZhang05 RZhang05 marked this pull request as ready for review September 25, 2024 17:59
SupunS
SupunS reviewed Oct 1, 2024
View reviewed changes
runtime/ast/expression.go Outdated Show resolved Hide resolved
runtime/ast/expression.go Outdated Show resolved Hide resolved
runtime/interpreter/interpreter_expression.go Outdated Show resolved Hide resolved
runtime/tests/interpreter/interpreter_test.go Show resolved Hide resolved
runtime/sema/check_string_template_expression.go Outdated Show resolved Hide resolved
runtime/parser/lexer/lexer.go Outdated Show resolved Hide resolved
runtime/parser/lexer/lexer.go Outdated Show resolved Hide resolved
runtime/parser/expression_test.go Show resolved Hide resolved
runtime/parser/expression.go Show resolved Hide resolved
runtime/parser/lexer/state.go Show resolved Hide resolved
@SupunS SupunS self-assigned this Oct 1, 2024
SupunS
SupunS reviewed Oct 2, 2024
View reviewed changes
Copy link
Member

@SupunS SupunS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just some minor cleanups

runtime/parser/expression.go Outdated Show resolved Hide resolved
runtime/parser/lexer/lexer.go Outdated Show resolved Hide resolved
runtime/sema/check_string_template_expression.go Outdated Show resolved Hide resolved
runtime/sema/check_string_template_expression.go Show resolved Hide resolved
runtime/parser/expression.go Show resolved Hide resolved
runtime/sema/check_string_template_expression.go Outdated Show resolved Hide resolved
SupunS
SupunS approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@SupunS SupunS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🎉

runtime/sema/elaboration.go Outdated Show resolved Hide resolved
@RZhang05 RZhang05 mentioned this pull request Oct 10, 2024
Closed
6 tasks
turbolent
turbolent reviewed Oct 15, 2024
View reviewed changes
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

runtime/ast/expression.go Show resolved Hide resolved
runtime/ast/expression.go Outdated Show resolved Hide resolved
runtime/parser/lexer/lexer.go Outdated Show resolved Hide resolved
runtime/sema/check_string_template_expression.go Outdated Show resolved Hide resolved
@turbolent
Copy link
Member

Can you please update the title to reflect the current proposal (e.g. description)?

@RZhang05 RZhang05 changed the title Limited string templates: $identifier Limited string templates: \(identifier) Oct 16, 2024
turbolent
turbolent reviewed Oct 16, 2024
View reviewed changes
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great progress! Only a couple minor issues left. Once resolved, this should be ready to get merged 👏

runtime/ast/expression.go Outdated Show resolved Hide resolved
runtime/ast/expression.go Show resolved Hide resolved
runtime/ast/expression.go Outdated Show resolved Hide resolved
runtime/tests/checker/string_test.go Outdated Show resolved Hide resolved
runtime/sema/check_string_template_expression.go Outdated Show resolved Hide resolved
runtime/sema/check_string_template_expression.go Outdated Show resolved Hide resolved
@turbolent turbolent mentioned this pull request Oct 16, 2024
Open
17 tasks
turbolent
turbolent approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 👏

@SupunS SupunS merged commit 3208a5d into onflow:feature/string-templates Oct 18, 2024
8 of 9 checks passed
@RZhang05 RZhang05 mentioned this pull request Oct 18, 2024
Draft
6 tasks
@RZhang05 RZhang05 deleted the identifier-string-template branch October 18, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SupunS SupunS SupunS approved these changes

@turbolent turbolent turbolent approved these changes

Assignees

@SupunS SupunS

Labels
Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RZhang05 @turbolent @SupunS