-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge destructor removal into stable cadence #2928
Merge destructor removal into stable cadence #2928
Conversation
…to sainati/ban-custom-destructors
…dence into sainati/default-event-parsing
…ence into sainati/default-event-checking
…dence into sainati/default-event-interpreting
Co-authored-by: Supun Setunga <[email protected]>
…to sainati/ban-custom-destructors
…dence into sainati/default-event-parsing
Cadence Benchstat comparisonThis branch with compared with the base branch onflow:feature/stable-cadence commit 2ac7503 Collapsed results for better readability
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## feature/stable-cadence #2928 +/- ##
==========================================================
- Coverage 80.04% 80.02% -0.03%
==========================================================
Files 344 344
Lines 81490 81580 +90
==========================================================
+ Hits 65227 65281 +54
- Misses 13955 13989 +34
- Partials 2308 2310 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Can't wait to get this merged
Co-authored-by: Bastian Müller <[email protected]>
…:onflow/cadence into sainati/merge-stable-cadence-destructors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still a few cases of argument order mixup for Equal
assertions. Maybe grep for \.Equal\(
in the diff to find all cases
Okay I think I got them all this time 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! 👏 🎉
@SupunS Could you please also have a final look?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Closes #2790
master
branchFiles changed
in the Github PR explorer