Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove StandardLibraryHandler method from TestFramework interface #2927

Merged

Conversation

m-Peter
Copy link
Contributor

@m-Peter m-Peter commented Nov 7, 2023

Closes #2898

Description

This method is no longer needed as part of the TestFramework interface, We remove it so that downstream dependencies (test providers) are not forced to implement it.

Note: I will follow-up with the necessary changes on the cadence-tools/test repository, to complete the removal of this method.


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bc259b2) 79.43% compared to head (8c4ac61) 79.43%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2927   +/-   ##
=======================================
  Coverage   79.43%   79.43%           
=======================================
  Files         332      332           
  Lines       79111    79111           
=======================================
  Hits        62842    62842           
  Misses      13958    13958           
  Partials     2311     2311           
Flag Coverage Δ
unittests 79.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@turbolent turbolent merged commit 9b0cb90 into onflow:master Nov 7, 2023
12 of 14 checks passed
@m-Peter m-Peter deleted the test-framework-remove-stdlib-handler branch January 12, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove StandardLibraryHandler function from the test Blockchain interface
2 participants