Capability controllers migration #2912

turbolent · 2023-10-31T01:15:32Z

Closes: #2875

Description

Improve the existing migration infrastructure (e.g. pass interpreter and path)
Implement two migrations, which
- Migrate existing links to capability controllers, and
- Migrate path capabilities to ID capabilities

Targeted PR against master branch
Linked to Github issue with discussion and accepted design OR link to spec that describes this work
Code follows the standards mentioned here
Updated relevant documentation
Re-reviewed Files changed in the Github PR explorer
Added appropriate labels

This reverts commit eae5bd3.

…alue storage functionality

…ues to be migrated

github-actions · 2023-10-31T01:24:56Z

Cadence Benchstat comparison

This branch with compared with the base branch onflow:master commit ba0e26e
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

	old.txt	new.txt
	time/op		delta
DecodeBatchEventsCCF-4	150ms ± 0%	149ms ± 0%	~	(p=1.000 n=1+1)
DecodeBatchEventsJSON-4	443ms ± 0%	455ms ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowFees.FeesDeducted-4	3.59µs ± 0%	3.20µs ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowFees.TokensWithdrawn-4	2.58µs ± 0%	2.37µs ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-4	3.73µs ± 0%	3.13µs ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-4	3.69µs ± 0%	3.45µs ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowIDTableStaking.NewWeeklyPayout-4	2.81µs ± 0%	2.44µs ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowIDTableStaking.RewardsPaid-4	3.38µs ± 0%	2.85µs ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowToken.TokensDeposited-4	3.23µs ± 0%	3.09µs ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowToken.TokensDeposited_with_nil_receiver-4	2.99µs ± 0%	2.86µs ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowToken.TokensMinted-4	2.55µs ± 0%	2.48µs ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowToken.TokensWithdrawn-4	3.09µs ± 0%	3.19µs ± 0%	~	(p=1.000 n=1+1)
DecodeJSON/FlowFees.FeesDeducted-4	10.8µs ± 0%	11.1µs ± 0%	~	(p=1.000 n=1+1)
DecodeJSON/FlowFees.TokensWithdrawn-4	7.00µs ± 0%	6.70µs ± 0%	~	(p=1.000 n=1+1)
DecodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-4	9.90µs ± 0%	10.15µs ± 0%	~	(p=1.000 n=1+1)
DecodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-4	13.7µs ± 0%	13.7µs ± 0%	~	(p=1.000 n=1+1)
DecodeJSON/FlowIDTableStaking.NewWeeklyPayout-4	6.95µs ± 0%	6.55µs ± 0%	~	(p=1.000 n=1+1)
DecodeJSON/FlowIDTableStaking.RewardsPaid-4	9.61µs ± 0%	8.68µs ± 0%	~	(p=1.000 n=1+1)
DecodeJSON/FlowToken.TokensDeposited-4	9.81µs ± 0%	9.01µs ± 0%	~	(p=1.000 n=1+1)
DecodeJSON/FlowToken.TokensDeposited_with_nil_receiver-4	8.81µs ± 0%	7.94µs ± 0%	~	(p=1.000 n=1+1)
DecodeJSON/FlowToken.TokensMinted-4	6.63µs ± 0%	6.83µs ± 0%	~	(p=1.000 n=1+1)
DecodeJSON/FlowToken.TokensWithdrawn-4	10.0µs ± 0%	8.9µs ± 0%	~	(p=1.000 n=1+1)
EncodeBatchEventsCCF-4	101ms ± 0%	103ms ± 0%	~	(p=1.000 n=1+1)
EncodeBatchEventsJSON-4	115ms ± 0%	123ms ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowFees.FeesDeducted-4	2.29µs ± 0%	2.36µs ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowFees.TokensWithdrawn-4	1.80µs ± 0%	1.84µs ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-4	2.30µs ± 0%	2.21µs ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-4	2.62µs ± 0%	2.51µs ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowIDTableStaking.NewWeeklyPayout-4	1.91µs ± 0%	1.79µs ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowIDTableStaking.RewardsPaid-4	1.99µs ± 0%	2.03µs ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowToken.TokensDeposited-4	2.03µs ± 0%	2.07µs ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowToken.TokensDeposited_with_nil_receiver-4	1.99µs ± 0%	2.03µs ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowToken.TokensMinted-4	1.84µs ± 0%	1.89µs ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowToken.TokensWithdrawn-4	2.08µs ± 0%	2.10µs ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowFees.FeesDeducted-4	2.82µs ± 0%	2.94µs ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowFees.TokensWithdrawn-4	1.60µs ± 0%	1.53µs ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-4	2.48µs ± 0%	2.39µs ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-4	3.54µs ± 0%	3.62µs ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowIDTableStaking.NewWeeklyPayout-4	1.62µs ± 0%	1.65µs ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowIDTableStaking.RewardsPaid-4	2.06µs ± 0%	2.05µs ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowToken.TokensDeposited-4	2.42µs ± 0%	2.36µs ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowToken.TokensDeposited_with_nil_receiver-4	1.83µs ± 0%	1.91µs ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowToken.TokensMinted-4	1.58µs ± 0%	1.61µs ± 0%	~	(p=1.000 n=1+1)
EncodeJSON/FlowToken.TokensWithdrawn-4	2.38µs ± 0%	2.32µs ± 0%	~	(p=1.000 n=1+1)
ExportType/composite_type-4	336ns ± 0%	325ns ± 0%	~	(p=1.000 n=1+1)
ExportType/simple_type-4	82.8ns ± 0%	79.3ns ± 0%	~	(p=1.000 n=1+1)
InterpretRecursionFib-4	2.55ms ± 0%	2.51ms ± 0%	~	(p=1.000 n=1+1)
NewInterpreter/new_interpreter-4	1.14µs ± 0%	1.11µs ± 0%	~	(p=1.000 n=1+1)
NewInterpreter/new_sub-interpreter-4	541ns ± 0%	590ns ± 0%	~	(p=1.000 n=1+1)
ParseArray-4	7.06ms ± 0%	7.02ms ± 0%	~	(p=1.000 n=1+1)
ParseDeploy/byte_array-4	10.6ms ± 0%	10.1ms ± 0%	~	(p=1.000 n=1+1)
ParseDeploy/decode_hex-4	1.20ms ± 0%	1.12ms ± 0%	~	(p=1.000 n=1+1)
ParseFungibleToken/With_memory_metering-4	182µs ± 0%	184µs ± 0%	~	(p=1.000 n=1+1)
ParseFungibleToken/Without_memory_metering-4	146µs ± 0%	143µs ± 0%	~	(p=1.000 n=1+1)
ParseInfix-4	6.07µs ± 0%	6.13µs ± 0%	~	(p=1.000 n=1+1)
QualifiedIdentifierCreation/One_level-4	2.47ns ± 0%	2.85ns ± 0%	~	(p=1.000 n=1+1)
QualifiedIdentifierCreation/Three_levels-4	96.6ns ± 0%	94.0ns ± 0%	~	(p=1.000 n=1+1)
RuntimeScriptNoop-4	4.50µs ± 0%	4.20µs ± 0%	~	(p=1.000 n=1+1)
SuperTypeInference/arrays-4	288ns ± 0%	277ns ± 0%	~	(p=1.000 n=1+1)
SuperTypeInference/composites-4	101ns ± 0%	104ns ± 0%	~	(p=1.000 n=1+1)
SuperTypeInference/integers-4	351ns ± 0%	335ns ± 0%	~	(p=1.000 n=1+1)
ValueIsSubtypeOfSemaType-4	86.8ns ± 0%	89.1ns ± 0%	~	(p=1.000 n=1+1)

	alloc/op		delta
DecodeBatchEventsCCF-4	66.1MB ± 0%	66.1MB ± 0%	~	(p=1.000 n=1+1)
DecodeBatchEventsJSON-4	244MB ± 0%	244MB ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowFees.FeesDeducted-4	1.39kB ± 0%	1.39kB ± 0%	~	(all equal)
DecodeCCF/FlowFees.TokensWithdrawn-4	1.20kB ± 0%	1.20kB ± 0%	~	(all equal)
DecodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-4	1.47kB ± 0%	1.47kB ± 0%	~	(all equal)
DecodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-4	1.48kB ± 0%	1.48kB ± 0%	~	(all equal)
DecodeCCF/FlowIDTableStaking.NewWeeklyPayout-4	1.25kB ± 0%	1.25kB ± 0%	~	(all equal)
DecodeCCF/FlowIDTableStaking.RewardsPaid-4	1.37kB ± 0%	1.37kB ± 0%	~	(all equal)
DecodeCCF/FlowToken.TokensDeposited-4	1.31kB ± 0%	1.31kB ± 0%	~	(all equal)
DecodeCCF/FlowToken.TokensDeposited_with_nil_receiver-4	1.30kB ± 0%	1.30kB ± 0%	~	(all equal)
DecodeCCF/FlowToken.TokensMinted-4	1.20kB ± 0%	1.20kB ± 0%	~	(all equal)
DecodeCCF/FlowToken.TokensWithdrawn-4	1.32kB ± 0%	1.32kB ± 0%	~	(all equal)
DecodeJSON/FlowFees.FeesDeducted-4	6.00kB ± 0%	6.00kB ± 0%	~	(all equal)
DecodeJSON/FlowFees.TokensWithdrawn-4	3.60kB ± 0%	3.60kB ± 0%	~	(all equal)
DecodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-4	5.43kB ± 0%	5.43kB ± 0%	~	(all equal)
DecodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-4	7.35kB ± 0%	7.35kB ± 0%	~	(all equal)
DecodeJSON/FlowIDTableStaking.NewWeeklyPayout-4	3.64kB ± 0%	3.64kB ± 0%	~	(all equal)
DecodeJSON/FlowIDTableStaking.RewardsPaid-4	4.54kB ± 0%	4.54kB ± 0%	~	(all equal)
DecodeJSON/FlowToken.TokensDeposited-4	4.88kB ± 0%	4.88kB ± 0%	~	(all equal)
DecodeJSON/FlowToken.TokensDeposited_with_nil_receiver-4	4.46kB ± 0%	4.46kB ± 0%	~	(all equal)
DecodeJSON/FlowToken.TokensMinted-4	3.60kB ± 0%	3.60kB ± 0%	~	(all equal)
DecodeJSON/FlowToken.TokensWithdrawn-4	4.88kB ± 0%	4.88kB ± 0%	~	(all equal)
EncodeBatchEventsCCF-4	62.4MB ± 0%	62.4MB ± 0%	~	(p=1.000 n=1+1)
EncodeBatchEventsJSON-4	39.1MB ± 0%	39.1MB ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowFees.FeesDeducted-4	1.22kB ± 0%	1.22kB ± 0%	~	(all equal)
EncodeCCF/FlowFees.TokensWithdrawn-4	1.17kB ± 0%	1.17kB ± 0%	~	(all equal)
EncodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-4	1.44kB ± 0%	1.44kB ± 0%	~	(all equal)
EncodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-4	1.41kB ± 0%	1.41kB ± 0%	~	(all equal)
EncodeCCF/FlowIDTableStaking.NewWeeklyPayout-4	1.34kB ± 0%	1.34kB ± 0%	~	(all equal)
EncodeCCF/FlowIDTableStaking.RewardsPaid-4	1.42kB ± 0%	1.42kB ± 0%	~	(all equal)
EncodeCCF/FlowToken.TokensDeposited-4	1.22kB ± 0%	1.22kB ± 0%	~	(all equal)
EncodeCCF/FlowToken.TokensDeposited_with_nil_receiver-4	1.20kB ± 0%	1.20kB ± 0%	~	(all equal)
EncodeCCF/FlowToken.TokensMinted-4	1.17kB ± 0%	1.17kB ± 0%	~	(all equal)
EncodeCCF/FlowToken.TokensWithdrawn-4	1.22kB ± 0%	1.22kB ± 0%	~	(all equal)
EncodeJSON/FlowFees.FeesDeducted-4	864B ± 0%	864B ± 0%	~	(all equal)
EncodeJSON/FlowFees.TokensWithdrawn-4	504B ± 0%	504B ± 0%	~	(all equal)
EncodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-4	888B ± 0%	888B ± 0%	~	(all equal)
EncodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-4	1.08kB ± 0%	1.08kB ± 0%	~	(all equal)
EncodeJSON/FlowIDTableStaking.NewWeeklyPayout-4	552B ± 0%	552B ± 0%	~	(all equal)
EncodeJSON/FlowIDTableStaking.RewardsPaid-4	752B ± 0%	752B ± 0%	~	(all equal)
EncodeJSON/FlowToken.TokensDeposited-4	776B ± 0%	776B ± 0%	~	(all equal)
EncodeJSON/FlowToken.TokensDeposited_with_nil_receiver-4	640B ± 0%	640B ± 0%	~	(all equal)
EncodeJSON/FlowToken.TokensMinted-4	512B ± 0%	512B ± 0%	~	(all equal)
EncodeJSON/FlowToken.TokensWithdrawn-4	768B ± 0%	768B ± 0%	~	(all equal)
ExportType/composite_type-4	120B ± 0%	120B ± 0%	~	(all equal)
ExportType/simple_type-4	0.00B	0.00B	~	(all equal)
InterpretRecursionFib-4	1.00MB ± 0%	1.00MB ± 0%	~	(p=1.000 n=1+1)
NewInterpreter/new_interpreter-4	928B ± 0%	928B ± 0%	~	(all equal)
NewInterpreter/new_sub-interpreter-4	200B ± 0%	200B ± 0%	~	(all equal)
ParseArray-4	2.71MB ± 0%	2.78MB ± 0%	~	(p=1.000 n=1+1)
ParseDeploy/byte_array-4	4.24MB ± 0%	4.24MB ± 0%	~	(p=1.000 n=1+1)
ParseDeploy/decode_hex-4	214kB ± 0%	214kB ± 0%	~	(all equal)
ParseFungibleToken/With_memory_metering-4	29.7kB ± 0%	29.7kB ± 0%	~	(all equal)
ParseFungibleToken/Without_memory_metering-4	29.7kB ± 0%	29.7kB ± 0%	~	(all equal)
ParseInfix-4	1.92kB ± 0%	1.92kB ± 0%	~	(p=1.000 n=1+1)
QualifiedIdentifierCreation/One_level-4	0.00B	0.00B	~	(all equal)
QualifiedIdentifierCreation/Three_levels-4	64.0B ± 0%	64.0B ± 0%	~	(all equal)
RuntimeScriptNoop-4	3.21kB ± 0%	3.21kB ± 0%	~	(all equal)
SuperTypeInference/arrays-4	96.0B ± 0%	96.0B ± 0%	~	(all equal)
SuperTypeInference/composites-4	0.00B	0.00B	~	(all equal)
SuperTypeInference/integers-4	0.00B	0.00B	~	(all equal)
ValueIsSubtypeOfSemaType-4	48.0B ± 0%	48.0B ± 0%	~	(all equal)

	allocs/op		delta
DecodeBatchEventsCCF-4	1.48M ± 0%	1.48M ± 0%	~	(p=1.000 n=1+1)
DecodeBatchEventsJSON-4	4.70M ± 0%	4.70M ± 0%	~	(p=1.000 n=1+1)
DecodeCCF/FlowFees.FeesDeducted-4	30.0 ± 0%	30.0 ± 0%	~	(all equal)
DecodeCCF/FlowFees.TokensWithdrawn-4	26.0 ± 0%	26.0 ± 0%	~	(all equal)
DecodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-4	30.0 ± 0%	30.0 ± 0%	~	(all equal)
DecodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-4	32.0 ± 0%	32.0 ± 0%	~	(all equal)
DecodeCCF/FlowIDTableStaking.NewWeeklyPayout-4	26.0 ± 0%	26.0 ± 0%	~	(all equal)
DecodeCCF/FlowIDTableStaking.RewardsPaid-4	29.0 ± 0%	29.0 ± 0%	~	(all equal)
DecodeCCF/FlowToken.TokensDeposited-4	31.0 ± 0%	31.0 ± 0%	~	(all equal)
DecodeCCF/FlowToken.TokensDeposited_with_nil_receiver-4	29.0 ± 0%	29.0 ± 0%	~	(all equal)
DecodeCCF/FlowToken.TokensMinted-4	26.0 ± 0%	26.0 ± 0%	~	(all equal)
DecodeCCF/FlowToken.TokensWithdrawn-4	31.0 ± 0%	31.0 ± 0%	~	(all equal)
DecodeJSON/FlowFees.FeesDeducted-4	126 ± 0%	126 ± 0%	~	(all equal)
DecodeJSON/FlowFees.TokensWithdrawn-4	71.0 ± 0%	71.0 ± 0%	~	(all equal)
DecodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-4	102 ± 0%	102 ± 0%	~	(all equal)
DecodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-4	159 ± 0%	159 ± 0%	~	(all equal)
DecodeJSON/FlowIDTableStaking.NewWeeklyPayout-4	70.0 ± 0%	70.0 ± 0%	~	(all equal)
DecodeJSON/FlowIDTableStaking.RewardsPaid-4	87.0 ± 0%	87.0 ± 0%	~	(all equal)
DecodeJSON/FlowToken.TokensDeposited-4	95.0 ± 0%	95.0 ± 0%	~	(all equal)
DecodeJSON/FlowToken.TokensDeposited_with_nil_receiver-4	86.0 ± 0%	86.0 ± 0%	~	(all equal)
DecodeJSON/FlowToken.TokensMinted-4	71.0 ± 0%	71.0 ± 0%	~	(all equal)
DecodeJSON/FlowToken.TokensWithdrawn-4	95.0 ± 0%	95.0 ± 0%	~	(all equal)
EncodeBatchEventsCCF-4	950k ± 0%	950k ± 0%	~	(p=1.000 n=1+1)
EncodeBatchEventsJSON-4	853k ± 0%	853k ± 0%	~	(p=1.000 n=1+1)
EncodeCCF/FlowFees.FeesDeducted-4	19.0 ± 0%	19.0 ± 0%	~	(all equal)
EncodeCCF/FlowFees.TokensWithdrawn-4	19.0 ± 0%	19.0 ± 0%	~	(all equal)
EncodeCCF/FlowIDTableStaking.DelegatorRewardsPaid-4	19.0 ± 0%	19.0 ± 0%	~	(all equal)
EncodeCCF/FlowIDTableStaking.EpochTotalRewardsPaid-4	19.0 ± 0%	19.0 ± 0%	~	(all equal)
EncodeCCF/FlowIDTableStaking.NewWeeklyPayout-4	19.0 ± 0%	19.0 ± 0%	~	(all equal)
EncodeCCF/FlowIDTableStaking.RewardsPaid-4	19.0 ± 0%	19.0 ± 0%	~	(all equal)
EncodeCCF/FlowToken.TokensDeposited-4	20.0 ± 0%	20.0 ± 0%	~	(all equal)
EncodeCCF/FlowToken.TokensDeposited_with_nil_receiver-4	20.0 ± 0%	20.0 ± 0%	~	(all equal)
EncodeCCF/FlowToken.TokensMinted-4	19.0 ± 0%	19.0 ± 0%	~	(all equal)
EncodeCCF/FlowToken.TokensWithdrawn-4	20.0 ± 0%	20.0 ± 0%	~	(all equal)
EncodeJSON/FlowFees.FeesDeducted-4	19.0 ± 0%	19.0 ± 0%	~	(all equal)
EncodeJSON/FlowFees.TokensWithdrawn-4	12.0 ± 0%	12.0 ± 0%	~	(all equal)
EncodeJSON/FlowIDTableStaking.DelegatorRewardsPaid-4	16.0 ± 0%	16.0 ± 0%	~	(all equal)
EncodeJSON/FlowIDTableStaking.EpochTotalRewardsPaid-4	25.0 ± 0%	25.0 ± 0%	~	(all equal)
EncodeJSON/FlowIDTableStaking.NewWeeklyPayout-4	12.0 ± 0%	12.0 ± 0%	~	(all equal)
EncodeJSON/FlowIDTableStaking.RewardsPaid-4	15.0 ± 0%	15.0 ± 0%	~	(all equal)
EncodeJSON/FlowToken.TokensDeposited-4	19.0 ± 0%	19.0 ± 0%	~	(all equal)
EncodeJSON/FlowToken.TokensDeposited_with_nil_receiver-4	14.0 ± 0%	14.0 ± 0%	~	(all equal)
EncodeJSON/FlowToken.TokensMinted-4	13.0 ± 0%	13.0 ± 0%	~	(all equal)
EncodeJSON/FlowToken.TokensWithdrawn-4	18.0 ± 0%	18.0 ± 0%	~	(all equal)
ExportType/composite_type-4	3.00 ± 0%	3.00 ± 0%	~	(all equal)
ExportType/simple_type-4	0.00	0.00	~	(all equal)
InterpretRecursionFib-4	18.9k ± 0%	18.9k ± 0%	~	(all equal)
NewInterpreter/new_interpreter-4	15.0 ± 0%	15.0 ± 0%	~	(all equal)
NewInterpreter/new_sub-interpreter-4	4.00 ± 0%	4.00 ± 0%	~	(all equal)
ParseArray-4	59.6k ± 0%	59.6k ± 0%	~	(p=1.000 n=1+1)
ParseDeploy/byte_array-4	89.5k ± 0%	89.4k ± 0%	~	(p=1.000 n=1+1)
ParseDeploy/decode_hex-4	63.0 ± 0%	63.0 ± 0%	~	(all equal)
ParseFungibleToken/With_memory_metering-4	778 ± 0%	778 ± 0%	~	(all equal)
ParseFungibleToken/Without_memory_metering-4	778 ± 0%	778 ± 0%	~	(all equal)
ParseInfix-4	48.0 ± 0%	48.0 ± 0%	~	(all equal)
QualifiedIdentifierCreation/One_level-4	0.00	0.00	~	(all equal)
QualifiedIdentifierCreation/Three_levels-4	2.00 ± 0%	2.00 ± 0%	~	(all equal)
RuntimeScriptNoop-4	51.0 ± 0%	51.0 ± 0%	~	(all equal)
SuperTypeInference/arrays-4	3.00 ± 0%	3.00 ± 0%	~	(all equal)
SuperTypeInference/composites-4	0.00	0.00	~	(all equal)
SuperTypeInference/integers-4	0.00	0.00	~	(all equal)
ValueIsSubtypeOfSemaType-4	1.00 ± 0%	1.00 ± 0%	~	(all equal)

codecov · 2023-10-31T01:35:26Z

Codecov Report

Attention: 256 lines in your changes are missing coverage. Please review.

Comparison is base (ba0e26e) 80.15% compared to head (909282d) 80.00%.
Report is 16 commits behind head on master.

Files	Patch %	Lines
runtime/interpreter/decode.go	36.75%	59 Missing and 15 partials ⚠️
runtime/interpreter/value_link.go	32.40%	70 Missing and 3 partials ⚠️
runtime/interpreter/value_pathcapability.go	45.54%	50 Missing and 5 partials ⚠️
migrations/capcons/linkmigration.go	85.64%	23 Missing and 6 partials ⚠️
migrations/capcons/error.go	0.00%	14 Missing ⚠️
runtime/interpreter/value.go	78.12%	3 Missing and 4 partials ⚠️
migrations/capcons/capabilitymigration.go	90.69%	3 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2912      +/-   ##
==========================================
- Coverage   80.15%   80.00%   -0.16%     
==========================================
  Files         348      353       +5     
  Lines       81944    82629     +685     
==========================================
+ Hits        65682    66106     +424     
- Misses      13942    14170     +228     
- Partials     2320     2353      +33

Flag	Coverage Δ
unittests	`80.00% <61.44%> (-0.16%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

migrations/capcons/linkmigration.go

runtime/interpreter/value.go

migrations/capcons/migration_test.go

…ys functions

… be performed

…ration

migrations/capcons/linkmigration.go

runtime/interpreter/value_link.go

runtime/interpreter/value_pathcapability.go

migrations/capcons/linkmigration.go

encoding/ccf/simpletype_test.go

migrations/capcons/capabilitymigration.go

migrations/capcons/linkmigration.go

Co-authored-by: Supun Setunga <[email protected]>

turbolent and others added 13 commits October 30, 2023 14:49

export link to capability controller migration

159ed58

start work on cap cons migration: migrate links of accounts

82b5389

migrate path capabilities which are stored in a storage map

d087fd1

migrate composites, optionals, arrays, and dictionaries

49c7e3e

Revert "use existing DeploymentTransaction helper"

4a6155a

This reverts commit eae5bd3.

clarify naming

ac2c791

add comments

393798b

bring back dependencies of cap cons migration

d880408

add new return value

0d43b6f

update tests to Cadence 1.0

7335183

bring back path capability value, path link value, and account link v…

de47719

…alue storage functionality

fix migration

72d7bfc

bring back tests: manually create path capability values and link val…

f9bd178

…ues to be migrated

turbolent added the Feature label Oct 31, 2023

turbolent mentioned this pull request Oct 31, 2023

Capability Controller migration #2500

Closed

6 tasks

turbolent added 13 commits October 31, 2023 11:09

ignore deprecation warnings, remove unused code

b1a7613

rename

67140e3

generalize link creation

e81209b

report cyclic errors instead of panic-ing

f96502b

report missing link target

44b8c4d

use existing storage, do not create another one

76b3ab0

refactor tests

c10c7b3

test missing source

b2969af

handle account links

4d56a32

test private account link

16e249b

support migrated links, do not require storage target to exists

08fb111

report and assert new borrow type

190b535

do not mutate while iterating

0ffefdc

turbolent added 2 commits December 6, 2023 09:20

add new location range argument

6c9ef05

fix lint

92b13a4

turbolent commented Dec 8, 2023

View reviewed changes

turbolent added 8 commits December 8, 2023 13:10

remove duplicated test case

0292cfe

turn TODO comment into explanation

3a0bff5

check if reporter exists

297682f

improve comment

3784a40

use new CompositeValue.ForEachFieldName and DictionaryValue.IterateKe…

b3778eb

…ys functions

separate commit from migration, so multiple sequential migrations can…

676ad21

… be performed

clean up, comment

bd1c39e

Merge branch 'feature/stable-cadence' into bastian/cap-cons-state-mig…

d8c7c42

…ration

turbolent mentioned this pull request Dec 8, 2023

Add state migration for removing all values from private domain #2974

Merged

6 tasks

Base automatically changed from feature/stable-cadence to master December 11, 2023 14:57

dsainati1 reviewed Dec 11, 2023

View reviewed changes

migrations/capcons/linkmigration.go Outdated Show resolved Hide resolved

runtime/interpreter/value_link.go Show resolved Hide resolved

runtime/interpreter/value_pathcapability.go Show resolved Hide resolved

migrations/capcons/linkmigration.go Show resolved Hide resolved

turbolent added 5 commits December 12, 2023 09:52

Merge branch 'master' into bastian/cap-cons-state-migration

8b2ee05

fix lint

cec2925

simplify

e46b8a9

also handle path to account link chains

e08a790

fix tests for re-added AuthAccount/PublicAccount primitive static types

f568221

SupunS approved these changes Dec 12, 2023

View reviewed changes

encoding/ccf/simpletype_test.go Outdated Show resolved Hide resolved

migrations/capcons/capabilitymigration.go Show resolved Hide resolved

migrations/capcons/linkmigration.go Show resolved Hide resolved

turbolent and others added 3 commits December 15, 2023 11:19

Update migrations/capcons/linkmigration.go

2996575

Merge branch 'master' into bastian/cap-cons-state-migration

b12ec56

Update encoding/ccf/simpletype_test.go

aee0846

Co-authored-by: Supun Setunga <[email protected]>

turbolent requested a review from dsainati1 December 16, 2023 00:20

dsainati1 approved these changes Dec 18, 2023

View reviewed changes

SupunS approved these changes Dec 18, 2023

View reviewed changes

fix lint

909282d

turbolent enabled auto-merge December 19, 2023 17:52

turbolent merged commit 866822a into master Dec 19, 2023
12 of 14 checks passed

turbolent deleted the bastian/cap-cons-state-migration branch December 19, 2023 18:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Capability controllers migration #2912

Capability controllers migration #2912

turbolent commented Oct 31, 2023 •

edited

Loading

github-actions bot commented Oct 31, 2023 •

edited

Loading

codecov bot commented Oct 31, 2023 •

edited

Loading

Capability controllers migration #2912

Capability controllers migration #2912

Conversation

turbolent commented Oct 31, 2023 • edited Loading

Description

github-actions bot commented Oct 31, 2023 • edited Loading

Cadence Benchstat comparison

codecov bot commented Oct 31, 2023 • edited Loading

Codecov Report

turbolent commented Oct 31, 2023 •

edited

Loading

github-actions bot commented Oct 31, 2023 •

edited

Loading

codecov bot commented Oct 31, 2023 •

edited

Loading