-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend type code generator #2806
Merged
turbolent
merged 2 commits into
feature/stable-cadence
from
bastian/extend-type-code-generator
Sep 23, 2023
Merged
Extend type code generator #2806
turbolent
merged 2 commits into
feature/stable-cadence
from
bastian/extend-type-code-generator
Sep 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ype check and run them
turbolent
force-pushed
the
bastian/extend-type-code-generator
branch
from
September 22, 2023 04:23
4575c6e
to
8bf8c38
Compare
turbolent
commented
Sep 22, 2023
dsainati1
approved these changes
Sep 22, 2023
SupunS
approved these changes
Sep 22, 2023
Base automatically changed from
bastian/constructor-initializer-function-type-helpers
to
feature/stable-cadence
September 23, 2023 17:05
Cadence Benchstat comparisonThis branch with compared with the base branch onflow:feature/stable-cadence commit 0b7ce62 Collapsed results for better readability
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #2805
Description
We might want to solve this in a general case for all type declaration in a follow-up PR.
sema
package. For example, ifInt
is mentioned in thecdc
file, generatesema.IntType
when the type code output is not generated intosema
.master
branchFiles changed
in the Github PR explorer