Remove support for custom destructors #2789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsainati1
added
the
Language Breaking Change
Cadence Benchstat comparisonThis branch with compared with the base branch onflow:feature/remove-destructors commit b9edc95 Collapsed results for better readability
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
dsainati1
commented
Sep 15, 2023
There was a problem hiding this comment.
Note that at the moment this doesn't have tests to enforce that the appropriate destructors run; we were previously doing this by setting flags in the body of the destructors, obviously this is no longer possible. However, once we implement support for default events, we can assert that the appropriate events are emitted when we expect in order to test this again.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## feature/remove-destructors #2789 +/- ##
==============================================================
- Coverage 80.02% 79.93% -0.10%
==============================================================
Files 344 344
Lines 81625 81388 -237
==============================================================
- Hits 65323 65059 -264
- Misses 13991 14018 +27
Partials 2311 2311
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
…to sainati/ban-custom-destructors
…to sainati/ban-custom-destructors
dsainati1
changed the base branch from
feature/destructor-removal
to
feature/stable-cadence
|
@turbolent @SupunS now that the FLIP associated with this is ready to be approved, this PR is ready for review |
…to sainati/ban-custom-destructors
turbolent
reviewed
Oct 25, 2023
SupunS
reviewed
Oct 25, 2023
dsainati1
changed the base branch from
feature/stable-cadence
to
feature/remove-destructors
…e into sainati/ban-custom-destructors
turbolent
approved these changes
Oct 27, 2023
SupunS
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2790
Reference implementation for onflow/flips#131, and as such will not be merged unless this FLIP is approved. This does not (yet) include support for default events
masterbranchFiles changedin the Github PR explorer