Cache normalized string #2777
Closed
Cache normalized string #2777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turbolent
added
the
Storage Breaking Change
dsainati1
approved these changes
Sep 11, 2023
This was referenced Sep 11, 2023
Cadence Benchstat comparisonThis branch with compared with the base branch onflow:feature/stable-cadence commit 9a146ab Collapsed results for better readability
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
SupunS
approved these changes
Sep 12, 2023
6 tasks
|
There's a bit of a problem with the lazy approach: Cadence currently stores Strings inline or as a separate slab, if too large. This is possible because strings are immutable. However, in this PR we're lazily normalizing the string, effectively "mutating" it (replacing it, with a potentially smaller or larger form). In the Discussing this in https://discord.com/channels/613813861610684416/1108479699732152503/1151271319548211210 Ideas:
I opened an implementation of the later as #2781 |
|
Closing in favor of #2781 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #2752
Description
String functions, like checking for equality, already operate on the normalized form of the string.
However, the results are currently discarded.
As strings are immutable, we can cache the normalized form and re-use it.
As the hash value is changed, this will need a migration. Given that we can perform breaking changes in the Stable Cadence release, we should use this opportunity.
masterbranchFiles changedin the Github PR explorer