Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EPIC] Enable testing of contract update to Cadence 1.0 in Emulator #2947

Closed
7 tasks done
j1010001 opened this issue Nov 17, 2023 · 6 comments
Closed
7 tasks done

[EPIC] Enable testing of contract update to Cadence 1.0 in Emulator #2947

j1010001 opened this issue Nov 17, 2023 · 6 comments

Comments

@j1010001
Copy link
Member

j1010001 commented Nov 17, 2023

Issue to be solved

Why: Developers need to test their ability to upgrade their existing contract to Cadence 1.0 version. When we release Emulator running Cadence 1.0, this would not be possible because if the upload of a contract that does not parse/typecheck with Cadence 1.0 will fail.

This step is required to collect data for the next stage, described in #2865.

Tasks for Emulator 1.0 RC1 release (enables dapp testing):

  1. Improvement
    turbolent
  2. Improvement
    turbolent
  3. Cadence 1.0 Feature Feedback
    jribbink

Suggested Solution

No response

@j1010001
Copy link
Member Author

Required for: onflow/flow-emulator#468

@j1010001
Copy link
Member Author

Can be closed after the new Emulator build is released.

@turbolent
Copy link
Member

turbolent commented Feb 9, 2024

Is the requirement for closing this issue that the updated update checker has been completed, or is that a separate issue/milestone?

I assume that work is part of #2865, in which case this issue can be considered in-review/done.

@j1010001
Copy link
Member Author

j1010001 commented Feb 9, 2024

Is the requirement for closing this issue that the updated update checker has been completed, or is that a separate issue/milestone?

I assume that work is part of #2865, in which case this issue can be considered in-review/done.

No, let's close this when the first version of this is out and create a new issue if the upgrade checker needs adjustments.

@j1010001 j1010001 added the Epic label Feb 26, 2024
@j1010001 j1010001 changed the title Enable testing of contract update to Cadence 1.0 in Emulator [EPIC] Enable testing of contract update to Cadence 1.0 in Emulator Feb 26, 2024
@j1010001 j1010001 assigned SupunS and unassigned dsainati1 Mar 7, 2024
@SupunS
Copy link
Member

SupunS commented Apr 2, 2024

I guess we can close this issue now?

@turbolent
Copy link
Member

Yeah, I think we can close this now, given there's no known work left to be done. 🎉 👏

We can maybe leave #3098 open until it's been confirmed that the latest CLI preview release works as expected.

@SupunS SupunS closed this as completed Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants