remove unsafeRandom

runtime/runtime_test.go

@@ -4468,10 +4468,7 @@ func TestRuntimeRandom(t *testing.T) {
 	script := []byte(`
       transaction {
         prepare() {
-          let rand1 = revertibleRandom()
-          log(rand1)
-          let rand2 = unsafeRandom()
-          log(rand2)
+          log(revertibleRandom())
         }
       }
     `)
@@ -4504,7 +4501,6 @@ func TestRuntimeRandom(t *testing.T) {
 	assert.Equal(t,
 		[]string{
 			"7558174677681708339",
-			"7558174677681708339",
 		},
 		loggedMessages,
 	)

runtime/stdlib/builtin.go

@@ -46,7 +46,6 @@ func DefaultStandardLibraryValues(handler StandardLibraryHandler) []StandardLibr
 		RLPContract,
 		NewLogFunction(handler),
 		NewRevertibleRandomFunction(handler),
-		NewUnsafeRandomFunction(handler),
 		NewGetBlockFunction(handler),
 		NewGetCurrentBlockFunction(handler),
 		NewGetAccountFunction(handler),

runtime/stdlib/random.go

@@ -68,41 +68,3 @@ func NewRevertibleRandomFunction(generator RandomGenerator) StandardLibraryValue
 		},
 	)
 }
-
-// `unsafeRandom` related constants and functions will be deleted
-// when the function is deprecated
-const unsafeRandomFunctionDocString = `
-Deprecated: Use revertibleRandom instead.
-
-Returns a pseudo-random number.
-
-NOTE: The use of this function is unsafe if not used correctly.
-
-Follow best practices to prevent security issues when using this function
-`
-
-var unsafeRandomFunctionType = revertibleRandomFunctionType
-
-func NewUnsafeRandomFunction(generator RandomGenerator) StandardLibraryValue {
-	return NewStandardLibraryFunction(
-		"unsafeRandom",
-		unsafeRandomFunctionType,
-		unsafeRandomFunctionDocString,
-		func(invocation interpreter.Invocation) interpreter.Value {
-			return interpreter.NewUInt64Value(
-				invocation.Interpreter,
-				func() uint64 {
-					var buffer [8]byte
-					var err error
-					errors.WrapPanic(func() {
-						err = generator.ReadRandom(buffer[:])
-					})
-					if err != nil {
-						panic(interpreter.WrappedExternalError(err))
-					}
-					return binary.LittleEndian.Uint64(buffer[:])
-				},
-			)
-		},
-	)
-}