test: improvements to Report Schema tests #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -188,12 +189,12 @@ public Object repeatRequestUntilStatusChanges( | |||
| Thread.sleep(sleepTime); | |||
|
|
|||
| if (isInstanceOfReport) { | |||
| instance = ((Report) method.invoke(onfido, params)).getActualInstance(); | |||
| instance = ((Report) method.invoke(onfido, params)).getReportShared(); | |||
There was a problem hiding this comment.
Actually this should be enough:
Suggested change
| instance = ((Report) method.invoke(onfido, params)).getReportShared(); | |
| instance = (Report) method.invoke(onfido, params); |
| Assertions.assertNotNull(documentReport.getResult()); | ||
| Assertions.assertNotNull(documentReport.getSubResult()); | ||
| Assertions.assertEquals(check.getId(), documentReport.getReportShared().getCheckId()); | ||
| Assertions.assertNotNull(((DocumentReport) documentReport.getActualInstance()).getBreakdown()); |
There was a problem hiding this comment.
There is no need to call getActualInstance() and cast the result. Just calling getDocumentReport() (or getFacialSimilarityPhotoFullyAutoReport() later on) would do the trick. ;)
sofia-gomes-onfido
force-pushed
the
test-improvements
branch
from
37db5e3 to
0a57d58
Compare
dvacca-onfido
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
getReportShared()to accessgetStatus()method instead ofgetActualInstance()in repeatRequestUntilStatusChanges method.