[ADD] (Web) HR Labels #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also includes PR feedback from first PR on different repo
ArneDeGeeter
force-pushed
the
16.0-hr-labels
branch
from
2a89343
to
da36a67
Compare
tarteo
requested changes
Mar 1, 2024
| default=True, | ||
| help="Disable showing this category on the filter options on the website", | ||
| ) | ||
| show_on_website = fields.Boolean( |
There was a problem hiding this comment.
Not sure, but is it possible to use website.published.mixin for this? or has it a diff functionality
There was a problem hiding this comment.
I think the mixin has more features than needed, it just needs the boolean, not any of the checks or an url.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.