Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Add] Added modules membership_group and mass_mailing_membership_group modules #68

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

ByteMeAsap
Copy link
Contributor

No description provided.

Copy link
Member

@tarteo tarteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!!

membership_group/models/membership_group.py Outdated Show resolved Hide resolved
membership_group/models/membership_group.py Outdated Show resolved Hide resolved
membership_group/menuitems.xml Show resolved Hide resolved
membership_group/views/res_partner_view.xml Outdated Show resolved Hide resolved
membership_group/views/membership_group_view.xml Outdated Show resolved Hide resolved
@tarteo tarteo force-pushed the 16.0-add-membership_group branch 2 times, most recently from 607d4af to 2757119 Compare November 14, 2024 14:29
Copy link
Member

@tarteo tarteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outside of the changes can you make allow_membership_registration default true, for at least the "main" website or add "default=True" . So we don't have to enable it after installation

@@ -10,13 +10,13 @@
"website": "https://www.onestein.nl",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice if this module is installed we have an applications menu in the membership menu, so people working with memberships don't have to switch to recruitement for it.

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added applications menu in members->configuration if membership_hr_recruitment module is installed

@ByteMeAsap
Copy link
Contributor Author

Outside of the changes can you make allow_membership_registration default true, for at least the "main" website or add "default=True" . So we don't have to enable it after installation

Added default=True

@ByteMeAsap ByteMeAsap force-pushed the 16.0-add-membership_group branch 2 times, most recently from 4be4230 to 91d52d1 Compare November 15, 2024 14:03
@ByteMeAsap ByteMeAsap force-pushed the 16.0-add-membership_group branch from 91d52d1 to 2d25cce Compare November 15, 2024 14:06
@ByteMeAsap ByteMeAsap merged commit 1ab7f78 into 16.0 Nov 15, 2024
1 of 3 checks passed
@ByteMeAsap ByteMeAsap deleted the 16.0-add-membership_group branch November 15, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants