18 add another version of a simpleexample #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin-delmas
added
documentation
Gaudeval
reviewed
Dec 11, 2024
Gaudeval
reviewed
Dec 11, 2024
Gaudeval
reviewed
Dec 11, 2024
Gaudeval
approved these changes
Dec 11, 2024
| rITFFile <- resultFiles.find(_.getName == s"${x.fullName}_itf_$i.txt") | ||
| rFreeFile <- resultFiles.find(_.getName == s"${x.fullName}_free_$i.txt") | ||
| } yield { | ||
| List(fileITF, fileFree) |
There was a problem hiding this comment.
Is this test done if the model x has less initiators than the reference? If it has more?
There was a problem hiding this comment.
Here the reference and the test must have the same number of initiator.
I can consider adding an assert to send a fail if the sizes mismatch
There was a problem hiding this comment.
I have added assert ensuring that all references are available
.../scala/onera/pmlanalyzer/views/interference/examples/mySys/MySysInterferenceGeneration.scala
Show resolved
Hide resolved
...la/onera/pmlanalyzer/views/interference/examples/mySys/MyProcInterferenceSpecification.scala
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please indicate whether this pull request [adds/removes/fixes/replaces] the [feature/bug/etc].
What type of pull request is this? (check all applicable)
Related Tickets & Documents
Solving issue 18 add another version of a simpleexample
Add service graph export
Add semantics export
Added tests?
Added to documentation?
Not totally true, but documentation of minor feature addition could be considered in further evolution
Do we need to update pml analyzer version?
Is this new version should be released as soon as possible?