Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support non load/store components #16

Merged
merged 5 commits into from
Apr 12, 2024
Merged

Conversation

Gaudeval
Copy link
Collaborator

Description

Add a flag to support the creation of hardware components without the default Load and Store services.

Help would be appreciated for:

  • test case generation: the current tests use ad-hoc definitions instead of neat generators
  • code quality: a shorter flag name might be better, unclear on Scala naming conventions.

What type of pull request is this? (check all applicable)

  • Feature
  • Bug Fix
  • Documentation Update
  • Style
  • Code Refactor
  • Performance Improvements
  • Test
  • Build
  • CI
  • Chore (Release)
  • Revert

Related Tickets & Documents

Closes #13

Added tests?

  • yes
  • no, because they aren't needed
  • no, because I need help

Added to documentation?

  • README.md
  • doc
  • no documentation needed

Do we need to update pml analyzer version?

  • no
  • the pull request is only a bug fix, need a bug fix version update
  • the pull request add new features and ensures retro-compatibility, need a feature addition version update
  • the pull request is not ensuring retro-capatibility, need a major version update
  • not sure, I need help

Is this new version should be released as soon as possible?

  • yes
  • no
  • not sure, I need help

@Gaudeval Gaudeval added the enhancement New feature or request label Apr 12, 2024
@Gaudeval Gaudeval linked an issue Apr 12, 2024 that may be closed by this pull request
Copy link
Collaborator

@kevin-delmas kevin-delmas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the development. It is very nice, just a little thing, please add the explicit parameter naming "withDefaultServices=" in you last test. It improve a bit the readability :-)

Copy link
Collaborator

@kevin-delmas kevin-delmas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 😄

@kevin-delmas kevin-delmas merged commit fb96ea5 into master Apr 12, 2024
1 check passed
@kevin-delmas kevin-delmas deleted the 13-components-services branch April 12, 2024 14:45
@Gaudeval
Copy link
Collaborator Author

Thank you for the development. It is very nice, just a little thing, please add the explicit parameter naming "withDefaultServices=" in you last test. It improve a bit the readability :-)

You drove a hard bargain, but it is done. The hardware test will have to become more FlatSpec-friendly one day. One day...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add services with either write or read but not both
2 participants