Merge pull request #831 from onekey-sec/830-permission-fixup

fix(permission): Ignore symlinks in fix_permission
onekey-sec · Apr 15, 2024 · 18787c3 · 18787c3
2 parents ff923a6 + 2f60a30
commit 18787c3
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/tests/integration/filesystem/squashfs/squashfs_v4_le/__input__/bad_symlink.squashfs b/tests/integration/filesystem/squashfs/squashfs_v4_le/__input__/bad_symlink.squashfs
diff --git a/...ration/filesystem/squashfs/squashfs_v4_le/__output__/bad_symlink.squashfs_extract/badlink b/...ration/filesystem/squashfs/squashfs_v4_le/__output__/bad_symlink.squashfs_extract/badlink
@@ -0,0 +1 @@
+etc/ssl/private/ssl-cert-snakeoil.key
diff --git a/unblob/extractor.py b/unblob/extractor.py
@@ -23,10 +23,10 @@ def carve_chunk_to_file(carve_path: Path, file: File, chunk: Chunk):
 
 
 def fix_permission(path: Path):
- if not path.exists():
+ if path.is_symlink():
  return
 
- if path.is_symlink():
+ if not path.exists():
  return
 
  mode = path.stat().st_mode