Rails 4 spree 2 3 #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ore paths - installer writes these to the vendor directory
…g a NullRefernce exception when viewing subscriptions in 'cart' status
…g which subscriptions are ready to be reordered. moved the processing inside of the model instead of in the rake task so that the two dont need to share logic. changed the order of some of the steps to work with spree-2-3. added a simple progress sanity checker - this should ideally use the state machine helper methods
| add_subscription variant_id, params[:subscriptions][:interval_id] | ||
| end if params[:variants] | ||
| end | ||
| params[:products].each { |product_id, variant_id| add_subscription(variant_id, interval_id) } if params[:products] |
There was a problem hiding this comment.
Unused block argument - product_id. If it's necessary, use _ or _product_id as an argument name to indicate that it won't be used.
Line is too long. [118/80]
|
@fattymiller Does this branch work? I need to set this up on a project and have spent all day upgrading the aloha branch to 2-3-stable.. to find this PR... :/ |
|
@acreilly Sorry to hear about your day! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump for Spree 2.3 that I needed