Skip to content

Commit

Permalink
fix: aria labels for input and buttons
Browse files Browse the repository at this point in the history
  • Loading branch information
HenryT-CG committed Oct 15, 2024
1 parent 1a16b2b commit f065f58
Show file tree
Hide file tree
Showing 15 changed files with 62 additions and 65 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@
icon="pi pi-times"
(onClick)="closeDialog()"
[label]="'ACTIONS.CANCEL' | translate"
[attr.aria-label]="'ACTIONS.CANCEL' | translate"
[ariaLabel]="'ACTIONS.CANCEL' | translate"
[pTooltip]="'ACTIONS.TOOLTIPS.CANCEL' | translate"
tooltipPosition="top"
tooltipEvent="hover"
Expand All @@ -173,7 +173,7 @@
[disabled]="!formGroup.valid"
(onClick)="saveWorkspace()"
[label]="'ACTIONS.CREATE.LABEL' | translate"
[attr.aria-label]="'ACTIONS.CREATE.LABEL' | translate"
[ariaLabel]="'ACTIONS.CREATE.LABEL' | translate"
[pTooltip]="'ACTIONS.CREATE.WORKSPACE.TOOLTIP' | translate"
tooltipPosition="top"
tooltipEvent="hover"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@
icon="pi pi-times"
(onClick)="workspaceDeleteVisible = false"
[label]="'ACTIONS.CONFIRMATION.NO' | translate"
[attr.aria-label]="'ACTIONS.CONFIRMATION.NO' | translate"
[ariaLabel]="'ACTIONS.CONFIRMATION.NO' | translate"
[pTooltip]="'ACTIONS.CONFIRMATION.NO.TOOLTIP' | translate"
tooltipPosition="top"
tooltipEvent="hover"
Expand All @@ -148,7 +148,7 @@
icon="pi pi-check"
(onClick)="onConfirmDeleteWorkspace()"
[label]="'ACTIONS.CONFIRMATION.YES' | translate"
[attr.aria-label]="'ACTIONS.CONFIRMATION.YES' | translate"
[ariaLabel]="'ACTIONS.CONFIRMATION.YES' | translate"
[pTooltip]="'ACTIONS.CONFIRMATION.YES.TOOLTIP' | translate"
tooltipPosition="top"
tooltipEvent="hover"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
[binary]="true"
styleClass="cursor-auto shadow-none ml-3"
[label]="'WORKSPACE_EXPORT.MENU' | translate"
[attr.aria-label]="'WORKSPACE_EXPORT.MENU' | translate"
[ariaLabel]="'WORKSPACE_EXPORT.MENU' | translate"
[pTooltip]="'WORKSPACE_EXPORT.MENU_TOOLTIP' | translate"
tooltipPosition="top"
tooltipEvent="hover"
Expand All @@ -34,7 +34,7 @@
icon="pi pi-times"
(onClick)="onClose()"
[label]="'ACTIONS.CONFIRMATION.NO' | translate"
[attr.aria-label]="'ACTIONS.CONFIRMATION.NO' | translate"
[ariaLabel]="'ACTIONS.CONFIRMATION.NO' | translate"
[pTooltip]="'ACTIONS.CONFIRMATION.NO.TOOLTIP' | translate"
tooltipPosition="top"
tooltipEvent="hover"
Expand All @@ -44,7 +44,7 @@
icon="pi pi-check"
(onClick)="onConfirmExportWorkspace()"
[label]="'ACTIONS.CONFIRMATION.YES' | translate"
[attr.aria-label]="'ACTIONS.CONFIRMATION.YES' | translate"
[ariaLabel]="'ACTIONS.CONFIRMATION.YES' | translate"
[pTooltip]="'ACTIONS.CONFIRMATION.YES.TOOLTIP' | translate"
tooltipPosition="top"
tooltipEvent="hover"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
[binary]="true"
[readonly]="true"
[label]="'INTERNAL.OPERATOR' | translate"
[attr.aria-label]="'INTERNAL.OPERATOR' | translate"
[ariaLabel]="'INTERNAL.OPERATOR' | translate"
[pTooltip]="'INTERNAL.TOOLTIPS.OPERATOR' | translate"
tooltipPosition="top"
tooltipEvent="hover"
Expand All @@ -21,7 +21,7 @@
[binary]="true"
[readonly]="true"
[label]="'INTERNAL.MANDATORY' | translate"
[attr.aria-label]="'INTERNAL.MANDATORY' | translate"
[ariaLabel]="'INTERNAL.MANDATORY' | translate"
[pTooltip]="'INTERNAL.TOOLTIPS.MANDATORY' | translate"
tooltipPosition="top"
tooltipEvent="hover"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
[binary]="true"
[readonly]="true"
[label]="'WORKSPACE.DISABLED' | translate"
[attr.aria-label]="'WORKSPACE.DISABLED' | translate"
[ariaLabel]="'WORKSPACE.DISABLED' | translate"
[pTooltip]="'WORKSPACE.TOOLTIPS.DISABLED' | translate"
tooltipPosition="top"
tooltipEvent="hover"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@
styleClass="h-full"
icon="pi pi-cog"
(onClick)="onGoToPermission()"
[attr.aria-label]="'ACTIONS.NAVIGATION.GOTO_WORKSPACE_PERMISSIONS' | translate"
[ariaLabel]="'ACTIONS.NAVIGATION.GOTO_WORKSPACE_PERMISSIONS' | translate"
[pTooltip]="'ACTIONS.NAVIGATION.GOTO_WORKSPACE_PERMISSIONS' | translate"
tooltipPosition="top"
tooltipEvent="hover"
Expand All @@ -78,7 +78,7 @@
styleClass="h-full"
icon="pi pi-plus"
(onClick)="onCreateRole($event)"
[attr.aria-label]="'ACTIONS.CREATE.ROLE' | translate"
[ariaLabel]="'ACTIONS.CREATE.ROLE' | translate"
[pTooltip]="'ACTIONS.CREATE.ROLE' | translate"
tooltipPosition="top"
tooltipEvent="hover"
Expand All @@ -90,7 +90,7 @@
styleClass="h-full"
icon="pi pi-refresh"
(onClick)="onReload()"
[attr.aria-label]="'ACTIONS.SEARCH.RELOAD' | translate"
[ariaLabel]="'ACTIONS.SEARCH.RELOAD' | translate"
[pTooltip]="'ACTIONS.SEARCH.RELOAD' | translate"
tooltipPosition="top"
tooltipEvent="hover"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
id="ws_slot_detail_item_slot_name"
class="pt-3 pb-2 text-responsive"
[value]="slot?.name"
[attr.aria-label]="'SLOT.NAME' | translate"
[ariaLabel]="'SLOT.NAME' | translate"
[pTooltip]="'SLOT.NAME' | translate"
tooltipPosition="top"
tooltipEvent="hover"
Expand All @@ -28,7 +28,6 @@
<p-tabPanel
id="ws_slot_detail_components"
[header]="'DIALOG.SLOT.TABS.COMPONENTS' | translate"
[attr.aria-label]="'DIALOG.SLOT.TABS.COMPONENTS' | translate"
[tooltip]="'DIALOG.SLOT.TABS.TOOLTIPS.COMPONENTS' | translate"
tooltipPosition="top"
tooltipEvent="hover"
Expand All @@ -53,7 +52,7 @@
<div class="flex flex-row justify-content-between align-items-center column-gap-2">
<div
class="flex-grow-1 font-semibold"
[attr.aria-label]="'DIALOG.SLOT.COMPONENTS.NOT_USED' | translate"
[ariaLabel]="'DIALOG.SLOT.COMPONENTS.NOT_USED' | translate"
[pTooltip]="'DIALOG.SLOT.COMPONENTS.NOT_USED.TOOLTIP' | translate"
tooltipPosition="top"
tooltipEvent="hover"
Expand All @@ -66,7 +65,7 @@
<div class="flex flex-row justify-content-between align-items-center column-gap-2">
<div
class="flex-grow-1 font-semibold"
[attr.aria-label]="'DIALOG.SLOT.COMPONENTS.USED' | translate"
[ariaLabel]="'DIALOG.SLOT.COMPONENTS.USED' | translate"
[pTooltip]="'DIALOG.SLOT.COMPONENTS.USED.TOOLTIP' | translate"
tooltipPosition="top"
tooltipEvent="hover"
Expand All @@ -81,7 +80,7 @@
*ngIf="component?.undeployed"
[id]="'ws_slot_detail_picklist_' + i + '_undeployed'"
class="card-badge-right badge-1 danger-action-text font-bold text-lg pi pi-ban"
[attr.aria-label]="'DIALOG.SLOT.UNDEPLOYED' | translate"
[ariaLabel]="'DIALOG.SLOT.UNDEPLOYED' | translate"
[pTooltip]="'DIALOG.SLOT.UNDEPLOYED.TOOLTIP' | translate"
tooltipPosition="top"
tooltipEvent="hover"
Expand All @@ -90,7 +89,7 @@
*ngIf="component?.deprecated && !component?.undeployed"
[id]="'ws_slot_detail_picklist_' + i + '_deprecated'"
class="card-badge-right badge-1 danger-action-text font-bold text-lg pi pi-exclamation-circle"
[attr.aria-label]="'DIALOG.SLOT.DEPRECATED' | translate"
[ariaLabel]="'DIALOG.SLOT.DEPRECATED' | translate"
[pTooltip]="'DIALOG.SLOT.DEPRECATED.TOOLTIP' | translate"
tooltipPosition="top"
tooltipEvent="hover"
Expand All @@ -114,7 +113,6 @@
<p-tabPanel
id="ws_slot_detail_products"
[header]="'DIALOG.SLOT.TABS.PRODUCTS' | translate"
[attr.aria-label]="'DIALOG.SLOT.TABS.PRODUCTS' | translate"
[tooltip]="'DIALOG.SLOT.TABS.TOOLTIPS.PRODUCTS' | translate"
tooltipPosition="top"
tooltipEvent="hover"
Expand All @@ -136,7 +134,7 @@
*ngIf="slot?.undeployed"
[id]="'ws_slot_detail_product_' + i + '_undeployed'"
class="danger-action-text text-md pi pi-ban"
[attr.aria-label]="'DIALOG.SLOT.UNDEPLOYED' | translate"
[ariaLabel]="'DIALOG.SLOT.UNDEPLOYED' | translate"
[pTooltip]="'DIALOG.SLOT.UNDEPLOYED' | translate"
tooltipPosition="top"
tooltipEvent="hover"
Expand All @@ -146,7 +144,7 @@
*ngIf="slot?.deprecated"
[id]="'ws_slot_detail_product_' + i + '_deprecated'"
class="danger-action-text text-md pi pi-exclamation-circle"
[attr.aria-label]="'DIALOG.SLOT.DEPRECATED' | translate"
[ariaLabel]="'DIALOG.SLOT.DEPRECATED' | translate"
[pTooltip]="'DIALOG.SLOT.DEPRECATED' | translate"
tooltipPosition="top"
tooltipEvent="hover"
Expand All @@ -161,7 +159,6 @@
<p-tabPanel
id="ws_slot_detail_intern"
[header]="'DIALOG.SLOT.TABS.INTERN' | translate"
[attr.aria-label]="'DIALOG.SLOT.TABS.INTERN' | translate"
[tooltip]="'DIALOG.SLOT.TABS.TOOLTIPS.INTERN' | translate"
tooltipPosition="top"
tooltipEvent="hover"
Expand All @@ -172,7 +169,7 @@
<div
id="ws_slot_detail_item_creation_date"
class="ocx-float-label-textbox pt-3 pb-2"
[attr.aria-label]="'INTERNAL.CREATION_DATE' | translate"
[ariaLabel]="'INTERNAL.CREATION_DATE' | translate"
[pTooltip]="'INTERNAL.TOOLTIPS.CREATION_DATE' | translate"
tooltipPosition="top"
tooltipEvent="hover"
Expand Down Expand Up @@ -204,7 +201,7 @@
<div
id="ws_slot_detail_item_modification_date"
class="ocx-float-label-textbox pt-3 pb-2"
[attr.aria-label]="'INTERNAL.MODIFICATION_DATE' | translate"
[ariaLabel]="'INTERNAL.MODIFICATION_DATE' | translate"
[pTooltip]="'INTERNAL.TOOLTIPS.MODIFICATION_DATE' | translate"
tooltipPosition="top"
tooltipEvent="hover"
Expand Down Expand Up @@ -243,7 +240,7 @@
icon="pi pi-times"
(onClick)="onClose()"
[label]="'ACTIONS.NAVIGATION.CLOSE' | translate"
[attr.aria-label]="'ACTIONS.NAVIGATION.CLOSE' | translate"
[ariaLabel]="'ACTIONS.NAVIGATION.CLOSE' | translate"
[pTooltip]="'ACTIONS.NAVIGATION.CLOSE.TOOLTIP' | translate"
tooltipPosition="top"
tooltipEvent="hover"
Expand Down Expand Up @@ -281,7 +278,7 @@
icon="pi pi-times"
(onClick)="onClose()"
[label]="'ACTIONS.CONFIRMATION.NO' | translate"
[attr.aria-label]="'ACTIONS.CONFIRMATION.NO' | translate"
[ariaLabel]="'ACTIONS.CONFIRMATION.NO' | translate"
[pTooltip]="'ACTIONS.CONFIRMATION.NO.TOOLTIP' | translate"
tooltipPosition="top"
tooltipEvent="hover"
Expand All @@ -291,7 +288,7 @@
icon="pi pi-check"
(onClick)="onDeleteSlot()"
[label]="'ACTIONS.CONFIRMATION.YES' | translate"
[attr.aria-label]="'ACTIONS.CONFIRMATION.YES' | translate"
[ariaLabel]="'ACTIONS.CONFIRMATION.YES' | translate"
[pTooltip]="'ACTIONS.CONFIRMATION.YES.TOOLTIP' | translate"
tooltipPosition="top"
tooltipEvent="hover"
Expand Down Expand Up @@ -328,7 +325,7 @@
icon="pi pi-times"
(onClick)="onDeregisterCancellation()"
[label]="'ACTIONS.CONFIRMATION.NO' | translate"
[attr.aria-label]="'ACTIONS.CONFIRMATION.NO' | translate"
[ariaLabel]="'ACTIONS.CONFIRMATION.NO' | translate"
[pTooltip]="'ACTIONS.CONFIRMATION.NO.TOOLTIP' | translate"
tooltipPosition="top"
tooltipEvent="hover"
Expand All @@ -339,7 +336,7 @@
iconPos="left"
(onClick)="onDeregisterConfirmation()"
[label]="'ACTIONS.CONFIRMATION.YES' | translate"
[attr.aria-label]="'ACTIONS.CONFIRMATION.YES' | translate"
[ariaLabel]="'ACTIONS.CONFIRMATION.YES' | translate"
[pTooltip]="'ACTIONS.CONFIRMATION.YES.TOOLTIP' | translate"
tooltipPosition="top"
tooltipEvent="hover"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
styleClass="h-full"
icon="pi pi-cog"
(onClick)="onGoToProductSlots()"
[attr.aria-label]="'ACTIONS.NAVIGATION.GOTO_PRODUCT_SLOTS' | translate"
[ariaLabel]="'ACTIONS.NAVIGATION.GOTO_PRODUCT_SLOTS' | translate"
[pTooltip]="'ACTIONS.NAVIGATION.GOTO_PRODUCT_SLOTS' | translate"
tooltipPosition="top"
tooltipEvent="hover"
Expand All @@ -52,7 +52,7 @@
styleClass="h-full"
icon="pi pi-refresh"
(onClick)="onReload()"
[attr.aria-label]="'ACTIONS.SEARCH.RELOAD' | translate"
[ariaLabel]="'ACTIONS.SEARCH.RELOAD' | translate"
[pTooltip]="'ACTIONS.SEARCH.RELOAD' | translate"
tooltipPosition="top"
tooltipEvent="hover"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
icon="pi pi-upload"
(onClick)="reset()"
[label]="'WORKSPACE_IMPORT.IMPORT_RESTART' | translate"
[attr.aria-label]="'WORKSPACE_IMPORT.IMPORT_RESTART' | translate"
[ariaLabel]="'WORKSPACE_IMPORT.IMPORT_RESTART' | translate"
[pTooltip]="'WORKSPACE_IMPORT.IMPORT_RESTART_TOOLTIP' | translate"
tooltipPosition="top"
tooltipEvent="hover"
Expand All @@ -49,7 +49,7 @@
icon="pi pi-arrow-left"
(onClick)="back()"
[label]="'ACTIONS.NAVIGATION.BACK' | translate"
[attr.aria-label]="'ACTIONS.NAVIGATION.BACK' | translate"
[ariaLabel]="'ACTIONS.NAVIGATION.BACK' | translate"
[pTooltip]="'ACTIONS.NAVIGATION.BACK.TOOLTIP' | translate"
tooltipPosition="top"
tooltipEvent="hover"
Expand All @@ -61,7 +61,7 @@
[disabled]="!isFormValid"
[label]="'ACTIONS.NAVIGATION.NEXT' | translate"
(onClick)="next()"
[attr.aria-label]="'ACTIONS.NAVIGATION.NEXT' | translate"
[ariaLabel]="'ACTIONS.NAVIGATION.NEXT' | translate"
[pTooltip]="'ACTIONS.NAVIGATION.NEXT.TOOLTIP' | translate"
tooltipPosition="top"
tooltipEvent="hover"
Expand All @@ -74,7 +74,7 @@
[disabled]="isLoading || !isFormValid"
(onClick)="importWorkspace()"
[label]="'WORKSPACE_IMPORT.IMPORT' | translate"
[attr.aria-label]="'WORKSPACE_IMPORT.START_IMPORT' | translate"
[ariaLabel]="'WORKSPACE_IMPORT.START_IMPORT' | translate"
[pTooltip]="'WORKSPACE_IMPORT.START_IMPORT' | translate"
tooltipPosition="top"
tooltipEvent="hover"
Expand All @@ -89,7 +89,7 @@
icon="pi pi-times"
(onClick)="onClose()"
[label]="'ACTIONS.NAVIGATION.CLOSE' | translate"
[attr.aria-label]="'ACTIONS.NAVIGATION.CLOSE_WITHOUT_SAVE' | translate"
[ariaLabel]="'ACTIONS.NAVIGATION.CLOSE_WITHOUT_SAVE' | translate"
[pTooltip]="'ACTIONS.NAVIGATION.CLOSE_WITHOUT_SAVE' | translate"
tooltipPosition="top"
tooltipEvent="hover"
Expand Down
Loading

0 comments on commit f065f58

Please sign in to comment.