Skip to content

Commit

Permalink
Fix code smell: added keyup event for color-picker span (#161)
Browse files Browse the repository at this point in the history
* fix: added keyup event for color-picker span

* fix: translation

* fix: use anchor tag as action element instead of span
  • Loading branch information
HenryT-CG authored Jul 1, 2024
1 parent 08b3529 commit 74c58b2
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
6 changes: 4 additions & 2 deletions src/app/theme/theme-designer/theme-designer.component.html
Original file line number Diff line number Diff line change
Expand Up @@ -217,13 +217,15 @@
</div>
</ng-template>
</p-overlayPanel>
<span
<a
tabindex="0"
id="theme_detail_item_color_{{ item }}_toggle"
class="p-inputgroup-addon cursor-pointer"
(click)="op.toggle($event)"
(keyup)="op.toggle($event)"
[ngStyle]="{ 'background-color': group.formGroup.value[item] }"
>
</span>
</a>
</div>
</div>
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/assets/i18n/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
"MODIFICATION_DATE": "Changed on",
"MODIFICATION_USER": "Changed by",
"OPERATOR": "Created by Operator",
"OPERATOR_MESSAGE": "This theme was created by the operator. All changes will be lost on the next deployment.",
"OPERATOR_MESSAGE": "This theme was created by the operator. All changes will be lost during the next deployment.",
"TOOLTIPS": {
"CREATION_DATE": "Timestamp of the creation",
"CREATION_USER": "Name of the user of the creation",
Expand Down

0 comments on commit 74c58b2

Please sign in to comment.