Skip to content

Commit

Permalink
fix: code smells
Browse files Browse the repository at this point in the history
  • Loading branch information
HenryT-CG committed Jan 3, 2025
1 parent ddf514b commit f84419d
Show file tree
Hide file tree
Showing 9 changed files with 62 additions and 205 deletions.
207 changes: 36 additions & 171 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@
"@swc/helpers": "0.5.13",
"@types/jest": "29.5.13",
"@types/node": "22.7.5",
"@typescript-eslint/eslint-plugin": "7.17.0",
"@typescript-eslint/eslint-plugin": "7.18.0",
"@typescript-eslint/parser": "7.18.0",
"eslint": "^8.57.1",
"eslint-config-prettier": "9.1.0",
Expand Down
6 changes: 3 additions & 3 deletions src/app/app.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ export class AppComponent implements OnInit {
title = 'shell'

constructor(
private translateService: TranslateService,
private config: PrimeNGConfig,
private userService: UserService
private readonly translateService: TranslateService,
private readonly config: PrimeNGConfig,
private readonly userService: UserService
) {}

ngOnInit(): void {
Expand Down
2 changes: 1 addition & 1 deletion src/app/shell/components/error-page.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ import { getLocation } from '@onecx/accelerator'
})
export class ErrorPageComponent {
requestedApplicationPath: string
constructor(private route: ActivatedRoute) {
constructor(private readonly route: ActivatedRoute) {
this.requestedApplicationPath = this.route.snapshot.paramMap.get('requestedApplicationPath') ?? ''
}

Expand Down
2 changes: 1 addition & 1 deletion src/app/shell/components/home/home.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import { Workspace } from '@onecx/integration-interface'
export class HomeComponent {
workspace$: Observable<Workspace | undefined>

constructor(private appStateService: AppStateService) {
constructor(private readonly appStateService: AppStateService) {
this.workspace$ = this.appStateService.currentWorkspace$.pipe(map((currentWorkspace) => currentWorkspace))
}
}
2 changes: 1 addition & 1 deletion src/app/shell/components/not-found-page.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import { Workspace } from '@onecx/integration-interface'
})
export class PageNotFoundComponent {
workspace: Workspace | undefined
constructor(private appStateService: AppStateService) {
constructor(private readonly appStateService: AppStateService) {
this.appStateService.currentMfe$.publish({
appId: '',
baseHref: '/',
Expand Down
6 changes: 3 additions & 3 deletions src/app/shell/services/permission-proxy.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@ import { PermissionBffService } from 'src/app/shared/generated'

@Injectable({ providedIn: 'root' })
export class PermissionProxyService {
private permissionsTopic$ = new PermissionsRpcTopic()
private readonly permissionsTopic$ = new PermissionsRpcTopic()

constructor(
private permissionsService: PermissionBffService,
private permissionsCacheService: PermissionsCacheService
private readonly permissionsService: PermissionBffService,
private readonly permissionsCacheService: PermissionsCacheService
) {}

async init(): Promise<unknown> {
Expand Down
Loading

0 comments on commit f84419d

Please sign in to comment.