fix: resolve issues (#10)

* fix: added missing targets

* fix: dockerfile

* fix: remove unnecessary test code and fix helm value

Dockerfile

@@ -1,4 +1,4 @@
-FROM ghcr.io/onecx/docker-spa-base:1.3.0
+FROM ghcr.io/onecx/docker-spa-base:1.6.0
 
 # Copy nginx configuration
 COPY nginx/locations.conf $DIR_LOCATION/locations.conf

helm/values.yaml

@@ -4,7 +4,7 @@ app:
     repository: 'onecx/onecx-search-config-ui'
   routing:
     enabled: true
-    path: /mfe/onecxSearchConfig/
+    path: /mfe/search-config/
 
   operator:
     # Microfrontend

package.json

@@ -10,7 +10,8 @@
     "lint": "nx lint",
     "lint:fix": "nx lint --fix",
     "test": "nx test",
-    "test:ci": "ng test --watch=false --browsers=ChromeHeadless --code-coverage"
+    "test:ci": "nx test --watch=false --browsers=ChromeHeadless --code-coverage",
+    "sonar": "npx sonarqube-scanner -Dproject.settings=sonar-local-project.properties"
   },
   "private": true,
   "husky": {

project.json

@@ -10,7 +10,7 @@
       "executor": "@nx/angular:webpack-browser",
       "outputs": ["{options.outputPath}"],
       "options": {
-        "outputPath": "dist/onecx-search-config",
+        "outputPath": "dist/onecx-search-config-ui",
         "index": "./src/index.html",
         "main": "./src/main.ts",
         "polyfills": "src/polyfills.ts",

src/app/remotes/column-group-selection/column-group-selection.component.spec.ts

@@ -27,7 +27,6 @@ import {
   PortalDialogService,
   PortalMessageService,
 } from '@onecx/portal-integration-angular';
-import { AppConfigService } from '@onecx/angular-integration-interface';
 import {
   Configuration,
   SearchConfigAPIService,
@@ -74,8 +73,6 @@ describe('OneCXColumnGroupSelectionComponent', () => {
     })),
   });
 
-  const appConfigSpy = createSpyObj('appConfig', []) as AppConfigService;
-
   const searchConfigServiceSpy = {
     ...createSpyObj('searchConfigService', [
       'getSearchConfigInfos',
@@ -219,10 +216,6 @@ describe('OneCXColumnGroupSelectionComponent', () => {
           ],
           providers: [
             DialogService,
-            {
-              provide: AppConfigService,
-              useValue: appConfigSpy,
-            },
             {
               provide: PortalDialogService,
               useValue: portalDialogSpy,

src/app/remotes/search-config/search-config.component.spec.ts

@@ -9,10 +9,7 @@ import {
   BASE_URL,
   RemoteComponentConfig,
 } from '@onecx/angular-remote-components';
-import {
-  AppConfigService,
-  AppStateService,
-} from '@onecx/angular-integration-interface';
+import { AppStateService } from '@onecx/angular-integration-interface';
 import { CommonModule } from '@angular/common';
 import { NO_ERRORS_SCHEMA, NgModule } from '@angular/core';
 import { provideHttpClientTesting } from '@angular/common/http/testing';
@@ -76,8 +73,6 @@ describe('OneCXSearchConfigComponent', () => {
     })),
   });
 
-  const appConfigSpy = createSpyObj('appConfig', []) as AppConfigService;
-
   const searchConfigServiceSpy = {
     ...createSpyObj('searchConfigService', [
       'getSearchConfigInfos',
@@ -218,10 +213,6 @@ describe('OneCXSearchConfigComponent', () => {
           ],
           providers: [
             DialogService,
-            {
-              provide: AppConfigService,
-              useValue: appConfigSpy,
-            },
             {
               provide: PortalDialogService,
               useValue: portalDialogSpy,