Skip to content

Commit

Permalink
fix: remove unnecessary test code and fix helm value
Browse files Browse the repository at this point in the history
  • Loading branch information
markuczy committed Oct 11, 2024
1 parent 9eac380 commit 4bc5681
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 18 deletions.
2 changes: 1 addition & 1 deletion helm/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ app:
repository: 'onecx/onecx-search-config-ui'
routing:
enabled: true
path: /mfe/onecxSearchConfig/
path: /mfe/search-config/

operator:
# Microfrontend
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ import {
PortalDialogService,
PortalMessageService,
} from '@onecx/portal-integration-angular';
import { AppConfigService } from '@onecx/angular-integration-interface';
import {
Configuration,
SearchConfigAPIService,
Expand Down Expand Up @@ -74,8 +73,6 @@ describe('OneCXColumnGroupSelectionComponent', () => {
})),
});

const appConfigSpy = createSpyObj('appConfig', []) as AppConfigService;

const searchConfigServiceSpy = {
...createSpyObj('searchConfigService', [
'getSearchConfigInfos',
Expand Down Expand Up @@ -219,10 +216,6 @@ describe('OneCXColumnGroupSelectionComponent', () => {
],
providers: [
DialogService,
{
provide: AppConfigService,
useValue: appConfigSpy,
},
{
provide: PortalDialogService,
useValue: portalDialogSpy,
Expand Down
11 changes: 1 addition & 10 deletions src/app/remotes/search-config/search-config.component.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,7 @@ import {
BASE_URL,
RemoteComponentConfig,
} from '@onecx/angular-remote-components';
import {
AppConfigService,
AppStateService,
} from '@onecx/angular-integration-interface';
import { AppStateService } from '@onecx/angular-integration-interface';
import { CommonModule } from '@angular/common';
import { NO_ERRORS_SCHEMA, NgModule } from '@angular/core';
import { provideHttpClientTesting } from '@angular/common/http/testing';
Expand Down Expand Up @@ -76,8 +73,6 @@ describe('OneCXSearchConfigComponent', () => {
})),
});

const appConfigSpy = createSpyObj('appConfig', []) as AppConfigService;

const searchConfigServiceSpy = {
...createSpyObj('searchConfigService', [
'getSearchConfigInfos',
Expand Down Expand Up @@ -218,10 +213,6 @@ describe('OneCXSearchConfigComponent', () => {
],
providers: [
DialogService,
{
provide: AppConfigService,
useValue: appConfigSpy,
},
{
provide: PortalDialogService,
useValue: portalDialogSpy,
Expand Down

0 comments on commit 4bc5681

Please sign in to comment.