Skip to content

Commit

Permalink
Fix double popup of upload image window (#213)
Browse files Browse the repository at this point in the history
* fix: double upload window pop up

* fix: bump deps

* fix: delete stopPropagation as it breaks tests

---------

Co-authored-by: Christian Badura <[email protected]>
  • Loading branch information
cbadura and Christian Badura authored Sep 6, 2024
1 parent f5a00f4 commit e2b07f7
Show file tree
Hide file tree
Showing 3 changed files with 24 additions and 25 deletions.
40 changes: 20 additions & 20 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -86,12 +86,12 @@
"@angular/cli": "~18.2.2",
"@angular/compiler-cli": "^18.2.2",
"@angular/language-service": "^18.2.2",
"@commitlint/cli": "^19.4.0",
"@commitlint/config-conventional": "^19.2.2",
"@commitlint/cli": "^19.4.1",
"@commitlint/config-conventional": "^19.4.1",
"@openapitools/openapi-generator-cli": "^2.13.4",
"@schematics/angular": "18.2.1",
"@types/jasmine": "~5.1.4",
"@types/node": "~22.5.0",
"@types/node": "~22.5.4",
"@typescript-eslint/eslint-plugin": "^7.18.0",
"@typescript-eslint/parser": "^7.18.0",
"css-loader": "^7.1.2",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -78,17 +78,16 @@

<!-- row 3 -->
<div class="flex flex-row flex-wrap sm:flex-nowrap align-items-center row-gap-2 column-gap-4">
<input hidden type="file" accept="image/*" #selectedFileInputLogo (change)="onFileUpload($event)" />
<app-image-container
id="ps_product_detail_form_field_logo"
[small]="true"
[imageUrl]="fetchingLogoUrl"
></app-image-container>
<input hidden type="file" accept="image/*" #selectedFileInputLogo (change)="onFileUpload($event)" />
<button
pButton
id="ps_product_detail_form_field_logo_upload"
icon="pi pi-upload"
(click)="selectedFileInputLogo.click()"
class="action-button p-button-icon-only"
[class.cursor-pointer]="changeMode === 'EDIT'"
[disabled]="changeMode === 'VIEW'"
Expand Down

0 comments on commit e2b07f7

Please sign in to comment.