Skip to content

Commit

Permalink
Show page report in paginator, mark svcs as readonly (#253)
Browse files Browse the repository at this point in the history
* feat: show page report in paginator, mark svcs as readonly

* feat: adjust translations

---------

Co-authored-by: Christian Badura <[email protected]>
  • Loading branch information
cbadura and Christian Badura authored Oct 1, 2024
1 parent b844b23 commit 047886b
Show file tree
Hide file tree
Showing 7 changed files with 12 additions and 4 deletions.
2 changes: 2 additions & 0 deletions src/app/product-store/app-search/app-search.component.html
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,8 @@
[filterBy]="filterValueDefault"
[sortField]="sortField"
[sortOrder]="sortOrder"
[showCurrentPageReport]="true"
currentPageReportTemplate="{first} - {last} {{ 'ACTIONS.SEARCH.OF' | translate }} {totalRecords}"
>
<ng-template pTemplate="header">
<div class="flex flex-wrap align-items-center mx-1">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,8 @@
filterBy="name,displayName,classification"
[sortField]="sortField"
[sortOrder]="sortOrder"
[showCurrentPageReport]="true"
currentPageReportTemplate="{first} - {last} {{ 'ACTIONS.SEARCH.OF' | translate }} {totalRecords}"
>
<ng-template pTemplate="header">
<ocx-data-view-controls
Expand Down
2 changes: 2 additions & 0 deletions src/app/product-store/slot-search/slot-search.component.html
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,8 @@
[rows]="20"
[sortField]="sortField"
[sortOrder]="sortOrder"
[showCurrentPageReport]="true"
currentPageReportTemplate="{first} - {last} {{ 'ACTIONS.SEARCH.OF' | translate }} {totalRecords}"
>
<ng-template pTemplate="header">
<ocx-data-view-controls
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export class ImageContainerComponent implements OnChanges {

prepareUrlPath = prepareUrlPath

constructor(private appState: AppStateService) {
constructor(private readonly appState: AppStateService) {
this.defaultImageUrl$ = appState.currentMfe$.pipe(
map((mfe) => {
return this.prepareUrlPath(mfe.remoteBaseUrl, environment.DEFAULT_LOGO_PATH)
Expand Down
2 changes: 1 addition & 1 deletion src/app/shared/label.resolver.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { Observable, map } from 'rxjs'
//dont use `providedIn root` - wont work when we are in shell
@Injectable()
export class LabelResolver implements Resolve<string> {
constructor(private translate: TranslateService) {}
constructor(private readonly translate: TranslateService) {}
resolve(route: ActivatedRouteSnapshot, _state: RouterStateSnapshot): string | Observable<string> | Promise<string> {
return route.data['breadcrumb']
? this.translate.get(route.data['breadcrumb']).pipe(map((t) => t.toString()))
Expand Down
3 changes: 2 additions & 1 deletion src/assets/i18n/de.json
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,8 @@
"NOT_EXISTS": "Eine Applikation mit diesem Namen konnte nicht gefunden werden.",
"LOAD_ERROR": "Applikation konnte nicht geladen werden",
"NOT_FOUND": "Applikation nicht gefunden"
}
},
"OF": "von"
},
"VIEW": {
"LABEL": "Ansehen",
Expand Down
3 changes: 2 additions & 1 deletion src/assets/i18n/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,8 @@
"NOT_EXISTS": "An Application with this name could not be found.",
"LOAD_ERROR": "Failed to load the Application",
"NOT_FOUND": "Application was not found"
}
},
"OF": "of"
},
"VIEW": {
"LABEL": "View",
Expand Down

0 comments on commit 047886b

Please sign in to comment.