fix: code smells (#242)

package.json

@@ -68,7 +68,7 @@
     "primeicons": "^7.0.0",
     "primeng": "^17.18.11",
     "rxjs": "7.8.1",
-    "tslib": "^2.7.0"
+    "tslib": "^2.8.0"
   },
   "devDependencies": {
     "@angular-devkit/build-angular": "^18.1.2",
@@ -93,7 +93,7 @@
     "css-loader": "^7.1.2",
     "eslint": "~8.57.1",
     "eslint-config-prettier": "9.1.0",
-    "eslint-plugin-import": "2.30.0",
+    "eslint-plugin-import": "2.31.0",
     "eslint-plugin-prettier": "^5.2.1",
     "husky": "^9.1.6",
     "jasmine-core": "~5.4.0",

src/app/onecx-permission-remote.module.ts

@@ -63,7 +63,7 @@ const routes: Routes = [
   schemas: []
 })
 export class OneCXPermissionModule implements DoBootstrap {
-  constructor(private injector: Injector) {
+  constructor(private readonly injector: Injector) {
     console.info('OneCX Permission Module constructor')
   }
 

src/app/permission/role-detail/role-detail.component.ts

@@ -31,10 +31,10 @@ export class RoleDetailComponent implements OnChanges {
   public selectedIamRoles: IAMRole[] = []
 
   constructor(
-    private roleApi: RoleAPIService,
-    private translate: TranslateService,
-    private msgService: PortalMessageService,
-    private userService: UserService
+    private readonly roleApi: RoleAPIService,
+    private readonly translate: TranslateService,
+    private readonly msgService: PortalMessageService,
+    private readonly userService: UserService
   ) {
     if (userService.hasPermission('ROLE#EDIT')) this.myPermissions.push('ROLE#EDIT')
     if (userService.hasPermission('ROLE#DELETE')) this.myPermissions.push('ROLE#DELETE')

src/app/remotes/user-roles-permissions/user-roles-permissions.component.ts

@@ -59,7 +59,7 @@ export class OneCXUserRolesPermissionsComponent implements OnInit, ocxRemoteComp
   public searchInProgress = false
 
   constructor(
-    @Inject(BASE_URL) private baseUrl: ReplaySubject<string>,
+    @Inject(BASE_URL) private readonly baseUrl: ReplaySubject<string>,
     private readonly userService: UserService,
     private readonly userApi: UserAPIService,
     private readonly translate: TranslateService

src/app/shared/label.resolver.ts

@@ -6,7 +6,7 @@ import { Observable, map } from 'rxjs'
 //dont use `providedIn root` - wont work when we are in shell
 @Injectable()
 export class LabelResolver implements Resolve<string> {
-  constructor(private translate: TranslateService) {}
+  constructor(private readonly translate: TranslateService) {}
   resolve(route: ActivatedRouteSnapshot, _state: RouterStateSnapshot): string | Observable<string> | Promise<string> {
     return route.data['breadcrumb']
       ? this.translate.get(route.data['breadcrumb']).pipe(map((t) => t.toString()))