Add permission for reading workspaces (#50)

* add permission for reading workspaces * fix permission setup for test
onecx · Jul 13, 2024 · 47f1de1 · 47f1de1
1 parent 481078b
commit 47f1de1
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 5 deletions.
diff --git a/docs/modules/onecx-announcement-bff/pages/onecx-announcement-bff-docs.adoc b/docs/modules/onecx-announcement-bff/pages/onecx-announcement-bff-docs.adoc
@@ -72,11 +72,13 @@ app:
       spec:
         permissions:
           announcement:
-            read: permission on all GET requests and POST search
+            read: permission on all GET requests and POST search including assigned meta data
             write: permission on PUT, POST, PATCH requests, where objects are saved or updated
             delete: permission on all DELETE requests
           product:
-            read: permission on all GET requests and POST search
+            read: permission to read available products/applications
+          workspace:
+            read: permission to read available workspaces
     keycloak:
       client:
         enabled: true

diff --git a/src/main/helm/values.yaml b/src/main/helm/values.yaml
@@ -9,11 +9,13 @@ app:
       spec:
         permissions:
           announcement:
-            read: permission on all GET requests and POST search
+            read: permission on all GET requests and POST search including assigned meta data
             write: permission on PUT, POST, PATCH requests, where objects are saved or updated
             delete: permission on all DELETE requests
           product:
-            read: permission on all GET requests and POST search
+            read: permission to read available products/applications
+          workspace:
+            read: permission to read available workspaces
     keycloak:
       client:
         enabled: true

diff --git a/src/main/openapi/openapi-bff.yaml b/src/main/openapi/openapi-bff.yaml
@@ -197,7 +197,7 @@ paths:
     get:
       x-onecx:
         permissions:
-          announcement:
+          workspace:
             - read
       tags:
         - AnnouncementInternal

diff --git a/src/test/resources/mockserver/permissions.json b/src/test/resources/mockserver/permissions.json
@@ -21,6 +21,7 @@
               "delete"
             ],
             "product": ["read"],
+            "workspace": ["read"],
             "permissions": [
               "admin-write",
               "admin-read"
@@ -51,6 +52,7 @@
               "read"
             ],
             "product": ["read"],
+            "workspace": ["read"],
             "permissions": [
               "admin-write",
               "admin-read"