Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example_data.sh so that it points to the correct location of docker-entrypoint.sh #105

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

kphurley
Copy link

When installing the project so I could hack on it, I ran into the issue described here: #84. I think this commit should fix and close that issue.

I noticed while doing a find for docker-entrypoint.sh that the location of this file inside of the container running the postgres process was tucked in /usr/local/bin. Changing the example_data.sh script to point to this location seems to correct this issue. After this change, I was able to seed the example data and run everything locally with no issues.

I also made a very minor change to the README to make running the server a tad more clear (there is no make run, I believe it should be make up 😄 )

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3e6b598) 99.81% compared to head (f3e6651) 99.81%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #105   +/-   ##
=======================================
  Coverage   99.81%   99.81%           
=======================================
  Files          45       45           
  Lines        2165     2165           
=======================================
  Hits         2161     2161           
  Misses          4        4           
Flag Coverage Δ
unittest 99.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@onecrayon onecrayon merged commit 6933f71 into onecrayon:main Feb 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants