Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ON-44002 # Submission disabled tooltip and class #730

Merged
merged 2 commits into from
Oct 3, 2024
Merged

ON-44002 # Submission disabled tooltip and class #730

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e67630
ON-44002 # Submission disabled tooltip and class
RyanButton Oct 3, 2024
62a3cc6
ON-44002 # Use clsx conditional class
RyanButton Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 27 additions & 19 deletions src/OneBlinkFormBase.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1224,28 +1224,36 @@ function OneBlinkFormBase({
</button>
)}
{isLastVisiblePage && (
<button
type="submit"
className={clsx(
'button ob-button is-success ob-button-submit cypress-submit-form-button cypress-submit-form',
{ 'is-loading': isPreparingToSubmit },
)}
disabled={
isPreview ||
disabled ||
isPreparingToSubmit ||
!submissionConditionallyEnabled
<Tooltip
title={
submissionConditionallyEnabled
? ''
: 'Submission disabled: Your inputs have not met the criteria for submission'
}
>
<CustomisableButtonInner
label={
isInfoPage
? 'Done'
: buttons?.submit?.label || 'Submit'
<button
type="submit"
className={clsx(
`button ob-button is-success ob-button-submit cypress-submit-form-button cypress-submit-form${submissionConditionallyEnabled ? '' : ' ob-button-submit-is-disabled'}`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clsx can handle conditionally including a class, e.g.
clsx('ob-steps-navigation', { 'is-active': isStepsHeaderActive, })}

{ 'is-loading': isPreparingToSubmit },
)}
disabled={
isPreview ||
disabled ||
isPreparingToSubmit ||
!submissionConditionallyEnabled
}
icon={buttons?.submit?.icon}
/>
</button>
>
<CustomisableButtonInner
label={
isInfoPage
? 'Done'
: buttons?.submit?.label || 'Submit'
}
icon={buttons?.submit?.icon}
/>
</button>
</Tooltip>
)}
</div>
)}
Expand Down