Fix command-buffer binary update implementation #2152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiomestre
force-pushed
the
fabio/binary_update_fix
branch
from
bbe7445
to
017d8f3
Compare
github-actions
bot
added
conformance
EwanC
approved these changes
Oct 2, 2024
|
going to merge this soon if you can fix the conflict @fabiomestre |
Fábio is on holiday, so me or @Bensuo will get to this. |
Bensuo
force-pushed
the
fabio/binary_update_fix
branch
from
6acd91a
to
3142142
Compare
|
@aarongreig Conflict should be fixed now, thanks! |
martygrant
pushed a commit
to intel/llvm
that referenced
this pull request
Oct 30, 2024
Bumps the UR tag and change the command-buffer update to pass nullptr to hNewKernel. Corresponding UR PR: oneapi-src/unified-runtime#2152 --------- Co-authored-by: Aaron Greig <[email protected]> Co-authored-by: Ewan Crawford <[email protected]>
YixingZhang007
pushed a commit
to YixingZhang007/llvm
that referenced
this pull request
Oct 30, 2024
…15569) Bumps the UR tag and change the command-buffer update to pass nullptr to hNewKernel. Corresponding UR PR: oneapi-src/unified-runtime#2152 --------- Co-authored-by: Aaron Greig <[email protected]> Co-authored-by: Ewan Crawford <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The command-buffer binary update implementation wasn't handling passing nullptr to hNewKernel properly. This PR fixes this issue.
intel/llvm PR: intel/llvm#15569