Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EXP][CMDBUF] Make command handle behaviour consistent #2131

Merged
merged 1 commit into from
Oct 21, 2024
Merged

[EXP][CMDBUF] Make command handle behaviour consistent #2131

merged 1 commit into from
Oct 21, 2024

Conversation

Bensuo
Copy link
Contributor

@Bensuo Bensuo commented Sep 25, 2024

  • Attempting to obtain a command handle when the command buffer is not updatable is now an error across all adapters
  • command-buffer spec and adapter code updated to reflect this
  • invalid_update CTS test updated to reflect new behaviour

@Bensuo Bensuo requested review from a team as code owners September 25, 2024 14:36
@github-actions github-actions bot added loader Loader related feature/bug conformance Conformance test suite issues. specification Changes or additions to the specification experimental Experimental feature additions/changes/specification level-zero L0 adapter specific issues cuda CUDA adapter specific issues hip HIP adapter specific issues command-buffer Command Buffer feature addition/changes/specification labels Sep 25, 2024
@Bensuo Bensuo mentioned this pull request Sep 26, 2024
Merged
@Bensuo
Copy link
Contributor Author

Bensuo commented Sep 26, 2024

DPC++ PR: intel/llvm#15522

@Bensuo Bensuo added the ready to merge Added to PR's which are ready to merge label Oct 2, 2024
@Bensuo Bensuo force-pushed the ben/command-handle-fix branch 3 times, most recently from bee945e to 508a453 Compare October 8, 2024 12:41
@aarongreig
Copy link
Contributor

looking at merging this soon if you can fix the conflicts @Bensuo

@Bensuo
[EXP][CMDBUF] Make command handle behaviour consistent
504d3b6 
- Attempting to obtain a command handle when the command buffer is not updatable is now an error across all adapters
- command-buffer spec and adapter code update to reflect this
- invalid_update CTS test updated to reflect new behaviour
- Add ability to query command-buffer descriptor properties
@Bensuo
Copy link
Contributor Author

Bensuo commented Oct 17, 2024

looking at merging this soon if you can fix the conflicts @Bensuo

Thanks! I've updated the branch and will keep an eye on the CI while it runs.

@kbenzie kbenzie merged commit c742ca4 into oneapi-src:main Oct 21, 2024
79 of 82 checks passed
steffenlarsen pushed a commit to intel/llvm that referenced this pull request Oct 22, 2024
@Bensuo @kbenzie
[SYCL][Graph] Only get command handle for updatable command-buffers (#…
c471c8c 
…15522)

- Update UR tag to include changes to command-handles
- Update calls to UrCommandBufferAppendKernelLaunch to only request
command handles for updatable command-buffers
- Only store command handles for updatable command-graphs

UR PR: oneapi-src/unified-runtime#2131

---------

Co-authored-by: Kenneth Benzie (Benie) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarongreig aarongreig aarongreig approved these changes

@EwanC EwanC EwanC approved these changes

Assignees
No one assigned
Labels
command-buffer Command Buffer feature addition/changes/specification conformance Conformance test suite issues. cuda CUDA adapter specific issues experimental Experimental feature additions/changes/specification hip HIP adapter specific issues level-zero L0 adapter specific issues loader Loader related feature/bug ready to merge Added to PR's which are ready to merge specification Changes or additions to the specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Bensuo @aarongreig @EwanC @kbenzie