github: workflows: Enable PR checks #2143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theComputeKid
force-pushed
the
pr-check
branch
6 times, most recently
from
b6e46da
to
fe226da
Compare
- Enforce that the length of the commit title is at most 72. - Enforce that the first word of the PR is followed by a colon. Signed-off-by: Hamza Butt <[email protected]>
theComputeKid
force-pushed
the
pr-check
branch
from
fe226da
to
1f6a871
Compare
mgouicem
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I promised @vpirogov that I would do this here.
For code reviewers, in order to test this on your local machine:
The free ubuntu github runners are sufficient for this purpose and have python natively installed so we are good.
TODO: Limit words before a colon (i.e. scopes) to allowed words.