sycl: update documentation #2129
Open
+77
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
densamoilov
reviewed
Sep 27, 2024
densamoilov
reviewed
Sep 27, 2024
src/gpu/generic/sycl/README.md
Outdated
| ## Concat | ||
|
|
||
| A generic Concat implementation which uses the Reorder primitive is used. Refer | ||
| to [src/gpu/generic/ref_concat.hpp](../ref_concat.hpp) for more information. |
There was a problem hiding this comment.
I think it's an implementation detail that may not be very useful for the users. Each primitive can have multiple implementations so I believe we just need to document what the primitive supports and not a particular implementation.
There was a problem hiding this comment.
Good point, added details.
sgeor255
force-pushed
the
svet/update-sycl-docs
branch
from
1a2a009
to
9c50b89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the documentation about SYCL primitives.