[cmake] fix condition for apple clang

[ilya-lavrenov]

Description

Cmake identifies Apple clang as "AppleClang"

Fixes # (github issue)

Checklist

General

• Do all unit and benchdnn tests (make test and make test_benchdnn_*) pass locally for each commit?
• Have you formatted the code using clang-format?

Performance improvements

• Have you submitted performance data that demonstrates performance improvements?

New features

• Have you published an RFC for the new feature?
• Was the RFC approved?
• Have you added relevant tests?

Bug fixes

• Have you included information on how to reproduce the issue (either in a github issue or in this PR)?
• Have you added relevant regression tests?

RFC PR

• Does RFC document follow the template?
• Have you added a link to the rendered document?

[vpirogov]

@ilya-lavrenov, CI results indicate that this is not the case for configuration we are testing. Which CMake version did you try?

[ilya-lavrenov]

We use 3.13 as minimum required.
Do you really need to support cmake 2.8.x ?

[densamoilov]

Do you really need to support cmake 2.8.x ?

Good question, we may have to bump the minimum required CMake version to at least 3.5 as the older versions have been deprecated in CMake 3.27.

[vpirogov]

Good question, we may have to bump the minimum required CMake version to at least 3.5 as the older versions have been deprecated in CMake 3.27.

We are using CMake 2.8.12 as minimal supported version to ensure RHEL 7 compatibility. As RHEL 7 is now out of production support we could bump it. RHEL8 has 3.11.4 and Ubuntu 20.04 has 3.16.3.

[spalicki]

Currently this check applied to all Clangs on macOS, after the change only to Apple provided Clang. If we want to retain the old logic, then MATCHES would be a better option like: if (APPLE AND CMAKE_CXX_COMPILER_ID MATCHES "Clang"). It should catch both Clangs.