Skip to content

Commit

Permalink
Remove Multidex usages
Browse files Browse the repository at this point in the history
Since the min SDK is 21, it is no longer necessary to use the Multidex library.

See the following for more info: https://developer.android.com/build/multidex#mdex-on-l
  • Loading branch information
MGaetan89 committed Oct 16, 2024
1 parent ddc4dfb commit 11d1045
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 20 deletions.
4 changes: 1 addition & 3 deletions configs.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,6 @@ ext {
mapboxAnnotationPluginVersion = "0.9.0"
mapboxSdkVersion = "9.7.1"
mapboxSdkTurfVersion = "7.2.0"
robolectricShadowsMultidexVersion = "4.13"
robolectricVersion = "4.13"
supportVersion = "1.0.0"
volleyVersion = "1.2.1"
Expand All @@ -123,13 +122,12 @@ ext {
mapboxSDKTurf = "com.mapbox.mapboxsdk:mapbox-sdk-turf:$mapboxSdkTurfVersion"
mapboxAnnotationPlugin = "com.mapbox.mapboxsdk:mapbox-android-plugin-annotation-v9:$mapboxAnnotationPluginVersion"
robolectric = "org.robolectric:robolectric:$robolectricVersion"
robolectricShadowsMultidex = "org.robolectric:shadows-multidex:$robolectricShadowsMultidexVersion"
}

ext.mapboxDependencies = { instance, configuration ->

configuration.implementation("com.mapbox.maps:android:$mapboxSdkVersion") {
transitive = true;
transitive = true
exclude group: 'com.android.support', module: 'support-v4'
exclude group: 'com.android.support', module: 'support-annotations'
exclude group: 'com.android.support', module: 'support-fragment'
Expand Down
16 changes: 6 additions & 10 deletions library/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ android {
versionCode 1
versionName this.version
testInstrumentationRunner 'androidx.test.runner.AndroidJUnitRunner'
multiDexEnabled true
}

buildTypes {
Expand All @@ -57,11 +56,11 @@ android {
properties.containsKey("mapbox.sdk.token")) {
buildConfigField "String", "MAPBOX_SDK_ACCESS_TOKEN", "\"" + localProperties["mapbox.sdk.token"] + "\""
} else {
println("One of the required config variables is not set in your local.properties");
println("One of the required config variables is not set in your local.properties")
buildConfigField "String", "MAPBOX_SDK_ACCESS_TOKEN", "\"sample_key\""
}
} else {
println("local.properties does not exist");
println("local.properties does not exist")
buildConfigField "String", "MAPBOX_SDK_ACCESS_TOKEN", "\"sample_key\""
}
}
Expand All @@ -77,11 +76,11 @@ android {
properties.containsKey("mapbox.sdk.token")) {
buildConfigField "String", "MAPBOX_SDK_ACCESS_TOKEN", "\"" + localProperties["mapbox.sdk.token"] + "\""
} else {
println("One of the required config variables is not set in your local.properties");
println("One of the required config variables is not set in your local.properties")
buildConfigField "String", "MAPBOX_SDK_ACCESS_TOKEN", "\"sample_key\""
}
} else {
println("local.properties does not exist");
println("local.properties does not exist")
buildConfigField "String", "MAPBOX_SDK_ACCESS_TOKEN", "\"sample_key\""

}
Expand All @@ -107,7 +106,7 @@ android {
dependencies { configuration ->
implementation 'androidx.legacy:legacy-support-v4:1.0.0'
implementation (mapboxSDK) {
transitive = true;
transitive = true
exclude group: 'com.android.support', module: 'support-v4'
exclude group: 'com.android.support', module: 'support-annotations'
exclude group: 'com.android.support', module: 'support-fragment'
Expand All @@ -123,7 +122,7 @@ dependencies { configuration ->
implementation (project(":utils")) {
// Uncomment the line below when creating releases
//implementation('io.ona.kujaku:utils:0.10.8-SNAPSHOT') {
transitive = true;
transitive = true
exclude group: 'com.mapbox.mapboxsdk', module: 'mapbox-android-sdk'
exclude group: 'com.android.support', module: 'support-v4'
}
Expand All @@ -134,8 +133,6 @@ dependencies { configuration ->
implementation 'com.jakewharton.threetenabp:threetenabp:1.1.1'
implementation 'com.jakewharton.timber:timber:5.0.1'

implementation 'androidx.multidex:multidex:2.0.1'

customDependencies(this, configuration)
appPermissionsDependencies(configuration)
infoWindowDependencies(this, configuration)
Expand All @@ -147,7 +144,6 @@ private static void testDependencies(instance, configuration) {
configuration.testImplementation instance.junit

configuration.testImplementation instance.robolectric
configuration.testImplementation instance.robolectricShadowsMultidex

configuration.testImplementation 'org.mockito:mockito-inline:5.2.0'

Expand Down
7 changes: 2 additions & 5 deletions sample/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ android {
versionCode getMasterCommitCount()
versionName getVersionName()

multiDexEnabled true
testInstrumentationRunner 'androidx.test.runner.AndroidJUnitRunner'
}

Expand Down Expand Up @@ -95,8 +94,6 @@ dependencies { configuration ->
exclude group: "com.android.support", module: "appcompat-v7"
}

implementation 'androidx.multidex:multidex:2.0.1'

testImplementation junit
testImplementation robolectric
}
Expand All @@ -111,15 +108,15 @@ private static void libraryModuleDevelopment(instance, configuration) {
}

configuration.implementation(instance.project(":utils")) {
transitive = true;
transitive = true
exclude group: 'com.mapbox.mapboxsdk', module: 'mapbox-android-sdk'
exclude group: 'com.android.support', module: 'support-v4'
exclude group: 'com.android.support', module: 'appcompat-v7'
exclude group: 'org.jacoco'
}

configuration.implementation(instance.mapboxSDK) {
transitive = true;
transitive = true
exclude group: 'com.android.support', module: 'support-v4'
exclude group: 'com.android.support', module: 'support-annotations'
exclude group: 'com.android.support', module: 'support-fragment'
Expand Down
5 changes: 3 additions & 2 deletions sample/src/main/java/io/ona/kujaku/sample/MyApplication.java
Original file line number Diff line number Diff line change
@@ -1,14 +1,15 @@
package io.ona.kujaku.sample;

import androidx.multidex.MultiDexApplication;
import io.ona.kujaku.KujakuLibrary;
import io.ona.kujaku.sample.repository.KujakuRepository;
import io.ona.kujaku.sample.repository.PointsRepository;
import timber.log.Timber;

import static io.ona.kujaku.sample.util.Constants.DATABASE_NAME;

public class MyApplication extends MultiDexApplication {
import android.app.Application;

public class MyApplication extends Application {

private static final String TAG = MyApplication.class.getName();

Expand Down

0 comments on commit 11d1045

Please sign in to comment.