Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add structure map generation tool to efsity #202

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Conversation

Wambere
Copy link
Contributor

@Wambere Wambere commented Jun 21, 2024

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #[issue number] or Closes #[issue number]

Engineer Checklist

  • I have run ./gradlew spotlessApply to check my code follows the project's style guide
  • I have built and run the efsity jar to verify my change fixes the issue and/or does not break the application

@Wambere
Copy link
Contributor Author

Wambere commented Aug 26, 2024

@sharon2719 @Lentumunai-Mark this is the PR that needs to be finished up to get the sm-tool integrated into efsity

@Wambere Wambere added the efsity FCT features label Aug 26, 2024
@sharon2719
Copy link
Contributor

@sharon2719 @Lentumunai-Mark this is the PR that needs to be finished up to get the sm-tool integrated into efsity

Noted @Wambere

@Lentumunai-Mark Lentumunai-Mark changed the title WIP: Add structure map generation tool to efsity Add structure map generation tool to efsity Sep 18, 2024
@Lentumunai-Mark Lentumunai-Mark marked this pull request as ready for review September 18, 2024 12:25
Copy link
Contributor Author

@Wambere Wambere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also add a new page under efsity/docs for this command with more information especially on the xls configuration file, what that should look like and an example

efsity/build.gradle.kts Outdated Show resolved Hide resolved
Copy link
Member

@pld pld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some notes so far, didn't get to review everything

@ndegwamartin
Copy link
Contributor

Could we also use version catalogs for these entries? -

implementation("ca.uhn.hapi.fhir:hapi-fhir-validation:6.8.0")
testImplementation(kotlin("test"))
testImplementation("junit:junit:4.13.2")
testImplementation("org.mockito:mockito-inline:3.12.4")
testImplementation("io.mockk:mockk:1.13.7")
testImplementation("org.mockito.kotlin:mockito-kotlin:4.1.0")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
efsity FCT features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants