Publish binary resources #194
Conversation
| ArrayList<String> resourceFiles = getResourceFiles(projectFolder); | ||
| String getFileName(String name) { | ||
| if ((name.endsWith("Register")) || (name.endsWith("Profile"))) { | ||
| String regex = "([a-z])([A-Z]+)"; |
There was a problem hiding this comment.
assuming here that we are always converting from camel case
There was a problem hiding this comment.
can you add that to a docstring for this function?
| String getBinaryContent(String fileName, String projectFolder) throws IOException { | ||
| String pathToFile; | ||
| if (fileName.contains("register")) { | ||
| pathToFile = projectFolder + "/registers/" + fileName; |
There was a problem hiding this comment.
assuming we're always using this agreed on file/folder structure
There was a problem hiding this comment.
yea seems reasonable, on that note, should we to the validation checker (and later the app content from template creator) something to verify the repo follows file structure?
There was a problem hiding this comment.
sure, created an issue here #195
| ArrayList<String> resourceFiles = getResourceFiles(projectFolder); | ||
| String getFileName(String name) { | ||
| if ((name.endsWith("Register")) || (name.endsWith("Profile"))) { | ||
| String regex = "([a-z])([A-Z]+)"; |
There was a problem hiding this comment.
can you add that to a docstring for this function?
| String getBinaryContent(String fileName, String projectFolder) throws IOException { | ||
| String pathToFile; | ||
| if (fileName.contains("register")) { | ||
| pathToFile = projectFolder + "/registers/" + fileName; |
There was a problem hiding this comment.
yea seems reasonable, on that note, should we to the validation checker (and later the app content from template creator) something to verify the repo follows file structure?
IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes #188
Engineer Checklist
./gradlew spotlessApplyto check my code follows the project's style guide