DictConfig.get() always returns None for non existing keys

news/425.bugfix

@@ -0,0 +1 @@
+DictConfig.get() in struct mode return None like standard Dict for non-existing keys

omegaconf/dictconfig.py

@@ -402,6 +402,8 @@ def __delitem__(self, key: DictKeyType) -> None:
     def get(self, key: DictKeyType, default_value: Any = DEFAULT_VALUE_MARKER) -> Any:
         try:
             return self._get_impl(key=key, default_value=default_value)
+        except ConfigAttributeError:
+            return None
         except Exception as e:
             self._format_and_raise(key=key, value=None, cause=e)
 

tests/test_struct.py

@@ -23,7 +23,7 @@ def test_struct_set_on_dict() -> None:
 
 
 def test_struct_set_on_nested_dict() -> None:
-    c = OmegaConf.create(dict(a=dict(b=10)))
+    c = OmegaConf.create({"a": {"b": 10}})
     OmegaConf.set_struct(c, True)
     with pytest.raises(AttributeError):
         # noinspection PyStatementEffect
@@ -37,7 +37,7 @@ def test_struct_set_on_nested_dict() -> None:
 
 
 def test_merge_dotlist_into_struct() -> None:
-    c = OmegaConf.create(dict(a=dict(b=10)))
+    c = OmegaConf.create({"a": {"b": 10}})
     OmegaConf.set_struct(c, True)
     with pytest.raises(AttributeError, match=re.escape("foo")):
         c.merge_with_dotlist(["foo=1"])
@@ -55,6 +55,11 @@ def test_merge_config_with_struct(
 
 
 def test_struct_contain_missing() -> None:
-    c = OmegaConf.create(dict())
+    c = OmegaConf.create()
     OmegaConf.set_struct(c, True)
     assert "foo" not in c
+
+
+@pytest.mark.parametrize("cfg", [{}, OmegaConf.create({}, flags={"struct": True})])
+def test_struct_dict_get(cfg: Any) -> None:
+    assert cfg.get("z") is None