Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add start_with that rule #97

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

git-audo
Copy link
Contributor

What

This pull request introduces a new feature to filter files on which to apply rules based on a prefix.

@omissis
Copy link
Owner

omissis commented Oct 26, 2024

Hey @git-audo thanks for the contrib, can you please rebase onto main? I should have fixed the issues with the tests. Thanks!

@git-audo
Copy link
Contributor Author

Hey @git-audo thanks for the contrib, can you please rebase onto main? I should have fixed the issues with the tests. Thanks!

@omissis the branch is already aligned with main, but it seems the CI is broken also on that branch.

@omissis omissis force-pushed the feature/add-start-with-rule branch 2 times, most recently from a753cdf to fe91c34 Compare November 4, 2024 00:15
@omissis omissis self-requested a review November 4, 2024 00:27
@omissis omissis force-pushed the feature/add-start-with-rule branch from fe91c34 to 83cf249 Compare November 4, 2024 00:29
@omissis omissis linked an issue Nov 4, 2024 that may be closed by this pull request
9 tasks
@omissis omissis enabled auto-merge (squash) November 4, 2024 00:29
@omissis omissis mentioned this pull request Nov 4, 2024
9 tasks
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 65.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 48.28%. Comparing base (a4fb016) to head (83cf249).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
internal/arch/file/that/start_with.go 65.00% 6 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #97       +/-   ##
===========================================
- Coverage   73.87%   48.28%   -25.59%     
===========================================
  Files          22       35       +13     
  Lines         842     1315      +473     
===========================================
+ Hits          622      635       +13     
- Misses        175      634      +459     
- Partials       45       46        +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@omissis omissis merged commit f96151d into omissis:main Nov 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement file's "that" expressions
3 participants