Refactor Helm Charts as per the reconfiguration/parametrization of paths in source code and Docker images #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arrobo, Gabriel <[email protected]>
|
OK to change it to yaml |
In this same PR? Or in another/new PR? |
|
If possible same PR would be good to avoid multiple review |
Signed-off-by: Arrobo, Gabriel <[email protected]>
Done. PR now includes change of extension of configuration files from |
Signed-off-by: Arrobo, Gabriel <[email protected]>
gab-arrobo
force-pushed
the
refactor-configuration
branch
from
94627c0
to
a6b8bde
Compare
thakurajayL
reviewed
Nov 13, 2024
thakurajayL
reviewed
Nov 13, 2024
Signed-off-by: Arrobo, Gabriel <[email protected]>
thakurajayL
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@thakurajayL,
Should we change the name (extension) of the config files to
yamlinstead ofconfbecause we already know that they are yaml files?