Fix non-functional linting warnings #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ran `golangci-lint run --fix` to automatically fix whitespace and import order warnings.
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
retest this please |
|
retest this please |
|
@ghislainbourgeois, I see several checks (components) are getting disabled in the golangci-linter. Is there a plan to re-enable them in future PRs? |
|
Yes, the goal is to disable them now as they are failed ng, making the CI green. Afterwards, create 1 PR per linter to enable it again and fixing the issues at the same time. This will make reviews a lot easier, and make sure we keep a green CI going forward. |
gab-arrobo
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran
golangci-lint run --fixto automatically fix whitespace and import order warnings.