-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add dry_run flag #44
base: main
Are you sure you want to change the base?
add dry_run flag #44
Conversation
Set dry_run flag as part of vals to be consumed within the process pool
It may be a good idea to write the data to a JSON or CSV file rather than print them, what do you think? |
printing to a file will make sense. Do we want a flag to indicate the output? |
I think we do not need another flag as we can set the |
you mean re-using |
validate the indexing if the dry_run is False
clean the up the code for writing JSON file
It is now writing a JSON file in case the dry_run is True, and printing to the console in case of any error. I have tested it and it seems to be working fine. |
Use the JSON format which is used to insert the data into Elasticsearch.
I have fixed the JSON format, it is similar to that used to insert the data into Elasticsearch. @joshmoore I have deployed it in
It will save the results to files named in this format: The files are saved to: |
The JSON is a list that contains dicts, each has a format like that:
|
for more information, see https://pre-commit.ci
this PR re-activates the work started by @joshmoore in #8