Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create release #597

Closed
wants to merge 2 commits into from
Closed

Create release #597

wants to merge 2 commits into from

Conversation

jburel
Copy link
Member

@jburel jburel commented Nov 14, 2024

This PR adds an action that will create a release when a tag is pushed
This will allow to check for upgrade in QA.

@sbesson
Copy link
Member

sbesson commented Nov 14, 2024

This will allow to check for upgrade in QA.

What's the relationship between a GitHub release and OME QA?

@jburel
Copy link
Member Author

jburel commented Nov 14, 2024

The "hit" endpoint checks if an upgrade is required. This only works for OMERO.server
I have adjusted the code so it also works for omero-web, insight
For that I checked what is the latest version available from GitHub using https://github.com/ome/omero-web/releases/latest

@sbesson
Copy link
Member

sbesson commented Nov 15, 2024

Thanks, you might be able to use the REST API directly as in https://api.github.com/repos/ome/omero-web/releases/latest

I'll leave @knabar to evaluate as he's going to be primarily involved here but I am not convinced that adding yet another GitHub workflow is justified here. Instead we could just update the release process and manually create a release after pushing the tag, this takes a few clicks and <30s using the current UI. Another potential caveat of the automated workflow is that we might not necessarily want to create GitHub releases for every tag and notably for release candidates if this API is going to be consumed by the OME upgrade check logic.

@jburel
Copy link
Member Author

jburel commented Nov 15, 2024

openmicroscopy and insight create a release.
That's why I picked that approach so I had the same piece of code to find the information
but if we don't want to create a release I will have to modify the code again i.e.

    r = requests.get(url)
    ver = regex.match(r.url).group(1)

If we want it to be manual, that's fine but from experience it tends to be forgotten
Also if we do not want to create on every tag, that can easily be added to the action

@jburel
Copy link
Member Author

jburel commented Nov 15, 2024

The url https://api.github.com/repos/ome/omero-web/releases/latest only works because I manually created a release
For example https://api.github.com/repos/ome/omero-py/releases/latest will not be helpful

@jburel
Copy link
Member Author

jburel commented Nov 15, 2024

I have now modified the code to use the REST API i.e. https://api.github.com/repos/ome/omero-web/tags
I will delete the release that I created manually

@jburel jburel closed this Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants