Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minimum batch size to avoid infinite loop due to zero batch size #594

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

knabar
Copy link
Member

@knabar knabar commented Nov 6, 2024

Fixes #593

Avoids infinite loops for tables with fewer than 10 rows (resulting in a zero batch size).

@knabar knabar added this to the 5.28.0 milestone Nov 6, 2024
@knabar knabar requested review from will-moore and jburel November 6, 2024 09:11
@knabar knabar self-assigned this Nov 6, 2024
Copy link
Member

@will-moore will-moore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple fix. Code looks good. 👍

@knabar knabar merged commit 2755194 into ome:master Nov 19, 2024
10 checks passed
@knabar knabar deleted the fix-small-table-download branch November 20, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infinite loop when downloading tables with <10 rows.
2 participants