-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block UI for some long running tasks #543
Conversation
This looks good and is working fine in testing. I wonder if we want to consolidate this with Having the 2 different blocking UIs for adjacent buttons is slightly unexpected, but certainly not a blocker. |
In testing, I noticed that "Save to All" functionality appears to ignore LUTs. The LUTs are used to generate thumbnails but are not actually saved, leading to a case where the thumbnails (with LUTs) are out of sync with the image rendering settings (without LUTs): |
Thanks for pointing that out - I'll dig in a bit and see if I can clean it up. |
Opened a new issue #552 |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code removal / update looks good and functionality is working, Thanks
The "Save to all" function in the Preview panel can take a long time to complete for datasets or plates that have lots of images. The user may refresh or reload the page before everything (including thumbnail refresh) completes, exacerbating the already high load on the server.
The same applies to copying and pasting rendering settings using the right-click menu in the tree.
This PR introduces a UI blocking dialog until thumbnails are reloaded:
The UI blocking is generic and can be used anywhere where a
Promise
is available:The dialog disappears automatically when the
Promise
resolves or rejects.By default the duration of the UI blocking is logged to the console: